kthread: convert the s390 qeth driver to use kthread
Subsystems (3)
PATCH 3/3 kthread: convert the s390 qeth driver to use kthread
Convert the s390 qeth driver, which can be a module, to use kthread rather than kernel_thread, whose EXPORT_SYMBOL is deprecated.
Compiles and boots, and dmesg shows it is in use for eth0.
Signed-off-by Serge E. Hallyn <[email protected]>
---
drivers/s390/net/qeth_main.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-)
315bee45e81ba606c009b59f8ad100bc5818eda3
drivers/s390/net/qeth_main.c +4 -6
@@ -50,6 +50,7 @@#include <linux/mii.h> #include <linux/rcupdate.h> #include <linux/ethtool.h> +#include <linux/kthread.h> #include <net/arp.h> #include <net/ip.h>
@@ -956,7 +957,6 @@ qeth_register_ip_addresses(void *ptr)struct qeth_card *card; card = (struct qeth_card *) ptr; -daemonize ("qeth_reg_ip" );QETH_DBF_TEXT (trace,4 ,"regipth1" );if (!qeth_do_run_thread (card,QETH_SET_IP_THREAD ))return 0 ;
@@ -974,7 +974,6 @@ qeth_set_promisc_mode(void *ptr) {struct qeth_card *card = (struct qeth_card *) ptr; -daemonize ("qeth_setprm" );QETH_DBF_TEXT (trace,4 ,"setprm1" );if (!qeth_do_run_thread (card,QETH_SET_PROMISC_MODE_THREAD ))return 0 ;
@@ -991,7 +990,6 @@ qeth_recover(void *ptr)int rc =0 ; card = (struct qeth_card *) ptr; -daemonize ("qeth_recover" );QETH_DBF_TEXT (trace,2 ,"recover1" );QETH_DBF_HEX (trace,2 , &card,sizeof (void *));if (!qeth_do_run_thread (card,QETH_RECOVER_THREAD ))
@@ -1048,11 +1046,11 @@ qeth_start_kernel_thread(struct qeth_carreturn ;if (qeth_do_start_thread (card,QETH_SET_IP_THREAD )) -kernel_thread (qeth_register_ip_addresses, (void *)card,SIGCHLD ); +kthread_run (qeth_register_ip_addresses, (void *)card,"qeth_reg_ip" );if (qeth_do_start_thread (card,QETH_SET_PROMISC_MODE_THREAD )) -kernel_thread (qeth_set_promisc_mode, (void *)card,SIGCHLD ); +kthread_run (qeth_set_promisc_mode, (void *)card,"qeth_setprm" );if (qeth_do_start_thread (card,QETH_RECOVER_THREAD )) -kernel_thread (qeth_recover, (void *) card,SIGCHLD ); +kthread_run (qeth_recover, (void *) card,"qeth_recover" ); }
Signature · 1 line
1.1.6
Quoted 4 lines · Serge E. Hallyn
Convert the s390 qeth driver, which can be a module, to use kthread rather than
kernel_thread, whoseEXPORT_SYMBOLis deprecated.Compiles and boots, and dmesg shows it is in use for eth0.
NACK. for the rationale see my reply to the lcs patch.