Disable core ulimit for user core process

PATCH New Andi Kleen 1 participant 1 message Aug 25, 2006

Share & tools

Andi Kleen

author

2006-08-25 09:01 UTC #0 lore raw

PATCH 1/1 Disable core ulimit for user core process

[I can't remember if I already sent this one off or not. If yes please ignore the dup.]
[This is an incremental patch for the user-core patch series which is in -mm]

Disable core files for pipe user helpers

This addresses one of the review comments earlier for the user core
patchkit: when the core dump handler is executed make sure there is no potential for recursion in case it crashes again.

This currently does it for all pipe user mode helpers. In theory it could be done only for core dump user helpers, but there are currently no other users of this function.

Signed-off-by Andi Kleen <[email protected]>

kernel/kmod.c +4 -0

Index: linux/kernel/kmod.c
===================================================================
@@ -35,6 +35,7 @@
 #include <linux/mount.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/resource.h>
 #include <asm/uaccess.h>
 
 extern int max_threads;

@@ -158,6 +159,9 @@ static int ____call_usermodehelper(void 
 		FD_SET(0, fdt->open_fds);
 		FD_CLR(0, fdt->close_on_exec);
 		spin_unlock(&f->file_lock);
+
+		/* and disallow core files too */
+		current->signal->rlim[RLIMIT_CORE] = (struct rlimit){0, 0};
 	}
 
 	/* We can run anywhere, unlike our parent keventd(). */