introduce TASK_DEAD state
Subsystems (3)
PATCH 3/3 introduce TASK_DEAD state
I am not sure about this patch, I am asking Ingo to take a decision.
task_struct->state == EXIT_DEAD is a very special case, to avoid a confusion it makes sense to introduce a new state, TASK_DEAD, while EXIT_DEAD should live only in ->exit_state as documented in sched.h.
Note that this state is not visible to user-space, get_task_state() masks off unsuitable states.
Signed-off-by Oleg Nesterov <[email protected]>
include/linux/sched.h renamed from include/linux/sched.h~3_rename +1 -0
@@ -148,6 +148,7 @@ extern unsigned long weighted_cpuload(co#define EXIT_DEAD 32/* in tsk->state again */ #define TASK_NONINTERACTIVE 64 +#define TASK_DEAD 128#define __set_task_state (tsk, state_value) \ do { (tsk)->state = (state_value); } while (0)
kernel/exit.c renamed from kernel/exit.c~3_rename +1 -1
@@ -955,7 +955,7 @@ fastcall NORET_TYPE void do_exit(long copreempt_disable ();/* causes final put_task_struct in finish_task_switch(). */ - tsk->state =EXIT_DEAD ; + tsk->state =TASK_DEAD ;schedule ();BUG ();
kernel/sched.c renamed from kernel/sched.c~3_rename +4 -4
@@ -1751,10 +1751,10 @@ static inline void finish_task_switch(st/* * A task struct has one reference for the use as "current". -* If a task dies, then it sets EXIT_DEAD in tsk->state and calls +* If a task dies, then it sets TASK_DEAD in tsk->state and calls * schedule one last time. The schedule call will never return, and * the scheduled task must drop that reference. -* The test for EXIT_DEAD must occur while the runqueue locks are +* The test for TASK_DEAD must occur while the runqueue locks are * still held, otherwise prev could be scheduled on another cpu, die * there before we look at prev->state, and then the reference would * be dropped twice.
@@ -1765,7 +1765,7 @@ static inline void finish_task_switch(stfinish_lock_switch (rq, prev);if (mm)mmdrop (mm); -if (unlikely (prev_state ==EXIT_DEAD )) { +if (unlikely (prev_state ==TASK_DEAD )) {/* * Remove function-return probe instances associated with this * task and put them back on the free list.
@@ -5116,7 +5116,7 @@ static void migrate_dead(unsigned int deBUG_ON (p->exit_state !=EXIT_ZOMBIE && p->exit_state !=EXIT_DEAD );/* Cannot have done final schedule yet: would have vanished. */ -BUG_ON (p->state ==EXIT_DEAD ); +BUG_ON (p->state ==TASK_DEAD );get_task_struct (p);
mm/oom_kill.c renamed from mm/oom_kill.c~3_rename +1 -1
@@ -206,7 +206,7 @@ static struct task_struct *select_bad_pr*/ releasing =test_tsk_thread_flag (p,TIF_MEMDIE ) || p->flags &PF_EXITING ; -if (releasing && (p->state !=EXIT_DEAD )) +if (releasing && (p->state !=TASK_DEAD ))return ERR_PTR (-1UL );if (p->flags &PF_SWAPOFF )return p;