it87: Cleanup set_fan_div
Subsystems (2)
PATCH 8/14 it87: Cleanup set_fan_div
Content-Disposition: inline; filename=hwmon-it87-set-fan-div.patch
it87: Cleanup set_fan_div
We only change one fan clock divider at a time, so there is only one fan min which needs to be saved and restored.
Signed-off-by Jean Delvare <khali at linux-fr.org>
--- drivers/hwmon/it87.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/hwmon/it87.c +7 -7
@@ -563,14 +563,14 @@struct i2c_client *client =to_i2c_client (dev);struct it87_data *data =i2c_get_clientdata (client);unsigned long val =simple_strtoul (buf,NULL ,10 ); -int i, min[3 ]; +int min;u8 old;mutex_lock (&data->update_lock); old =it87_read_value (client,IT87_REG_FAN_DIV ); -for (i =0 ; i <3 ; i++) - min[i] =FAN_FROM_REG (data->fan_min[i],DIV_FROM_REG (data->fan_div[i])); +/* Save fan min limit */ + min =FAN_FROM_REG (data->fan_min[nr],DIV_FROM_REG (data->fan_div[nr]));switch (nr) {case 0 :
@@ -590,10 +590,10 @@ val |=0x1 <<6 ;it87_write_value (client,IT87_REG_FAN_DIV , val); -for (i =0 ; i <3 ; i++) { - data->fan_min[i]úN_TO_REG(min[i], DIV_FROM_REG(data->fan_div[i])); -it87_write_value (client,IT87_REG_FAN_MIN (i), data->fan_min[i]); - } +/* Restore fan min limit */ + data->fan_min[nr] =FAN_TO_REG (min,DIV_FROM_REG (data->fan_div[nr])); +it87_write_value (client,IT87_REG_FAN_MIN (nr), data->fan_min[nr]); +mutex_unlock (&data->update_lock);return count; }
Signature · 1 line
Jean Delvare