acpi-cpufreq and software coordination
PATCH 1/1 acpi-cpufreq and software coordination
There is a bug in software coordination patch in acpi-cpufreq, due to which frequency will only be set on first CPU of any coordinated group. Bug identified by Denis, was not recognised earlier as there are no platforms yet that use software coordination with acpi-cpufreq driver.
Signed-off-by Denis Sadykov <[email protected]>
Signed-off-by Venkatesh Pallipadi <[email protected]>
arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c +8 -3
@@ -196,6 +196,7 @@ acpi_cpufreq_target ( unsigned int relation) {struct cpufreq_acpi_io *data = acpi_io_data[policy->cpu]; +struct cpufreq_acpi_io *cpudata;struct acpi_processor_performance *perf;struct cpufreq_freqs freqs;cpumask_t online_policy_cpus;
@@ -259,7 +260,8 @@ acpi_cpufreq_target (break ; } - result =acpi_processor_set_performance (data, j, next_state); + cpudata = acpi_io_data[j]; + result =acpi_processor_set_performance (cpudata, j, next_state);if (result) { result = -EAGAIN ;break ;
@@ -286,8 +288,11 @@ acpi_cpufreq_target (if (!cpus_empty (covered_cpus)) {for_each_cpu_mask (j, covered_cpus) { - policy->cpu = j; -acpi_processor_set_performance (data, +cpus_clear (set_mask); +cpu_set (j, set_mask); +set_cpus_allowed (current, set_mask); + cpudata = acpi_io_data[j]; +acpi_processor_set_performance (cpudata, j, cur_state); }