Replace uses of strdup with xstrdup.
PATCH 1/1 Replace uses of strdup with xstrdup.
Like xmalloc and xrealloc xstrdup dies with a useful message if the native strdup() implementation returns NULL rather than a valid pointer.
I just tried to use xstrdup in new code and found it to be missing. However I expected it to be present as xmalloc and xrealloc are already commonly used throughout the code.
Signed-off-by Shawn O. Pearce <[email protected]>
--- blame.c | 2 +- builtin-apply.c | 2 +- builtin-fmt-merge-msg.c | 22 +++++++++++----------- builtin-grep.c | 2 +- builtin-name-rev.c | 2 +- builtin-prune.c | 2 +- builtin-push.c | 10 +++++----- builtin-repo-config.c | 6 +++--- builtin-rev-list.c | 4 ++-- builtin-rm.c | 2 +- builtin-show-branch.c | 6 +++--- builtin-symbolic-ref.c | 4 ++-- builtin-tar-tree.c | 2 +- builtin-upload-tar.c | 2 +- builtin-zip-tree.c | 4 ++-- commit.c | 2 +- config.c | 8 ++++---- connect.c | 6 +++--- diff.c | 4 ++-- environment.c | 2 +- fetch.c | 4 ++-- fsck-objects.c | 2 +- git-compat-util.h | 8 ++++++++ git.c | 2 +- http-fetch.c | 2 +- http-push.c | 6 +++--- imap-send.c | 12 ++++++------ merge-file.c | 2 +- merge-recursive.c | 14 +++++++------- merge-tree.c | 4 ++-- path-list.c | 2 +- refs.c | 4 ++-- server-info.c | 2 +- sha1_file.c | 8 ++++---- sha1_name.c | 4 ++-- 35 files changed, 89 insertions(+), 81 deletions(-)
blame.c +1 -1
@@ -617,7 +617,7 @@ static void simplify_commit(struct rev_iif (new_name) {struct util_info * putil =get_util (p);if (!putil->pathname) - putil->pathname =strdup (new_name); + putil->pathname =xstrdup (new_name); }else { *pp = parent->next;continue ;
builtin-apply.c +1 -1
@@ -2449,7 +2449,7 @@ static int apply_patch(int fd, const chastatic int git_apply_config (const char *var,const char *value) {if (!strcmp (var,"apply.whitespace" )) { - apply_default_whitespace =strdup (value); + apply_default_whitespace =xstrdup (value);return 0 ; }return git_default_config (var, value);
builtin-fmt-merge-msg.c +11 -11
@@ -111,29 +111,29 @@ static int handle_line(char *line) i =find_in_list (&srcs, src);if (i <0 ) { i = srcs.nr; -append_to_list (&srcs,strdup (src), +append_to_list (&srcs,xstrdup (src),xcalloc (1 ,sizeof (struct src_data ))); } src_data = srcs.payload[i];if (pulling_head) { - origin =strdup (src); + origin =xstrdup (src); src_data->head_status |=1 ; }else if (!strncmp (line,"branch " ,7 )) { - origin =strdup (line +7 ); + origin =xstrdup (line +7 );append_to_list (&src_data->branch, origin,NULL ); src_data->head_status |=2 ; }else if (!strncmp (line,"tag " ,4 )) { origin = line; -append_to_list (&src_data->tag,strdup (origin +4 ),NULL ); +append_to_list (&src_data->tag,xstrdup (origin +4 ),NULL ); src_data->head_status |=2 ; }else if (!strncmp (line,"remote branch " ,14 )) { - origin =strdup (line +14 ); + origin =xstrdup (line +14 );append_to_list (&src_data->r_branch, origin,NULL ); src_data->head_status |=2 ; }else { - origin =strdup (src); -append_to_list (&src_data->generic,strdup (line),NULL ); + origin =xstrdup (src); +append_to_list (&src_data->generic,xstrdup (line),NULL ); src_data->head_status |=2 ; }
@@ -145,7 +145,7 @@ static int handle_line(char *line) new_origin[len -1 ] =0 ; origin = new_origin; }else - origin =strdup (origin); + origin =xstrdup (origin); }else {char *new_origin =xmalloc (strlen (origin) +strlen (src) +5 );sprintf (new_origin,"%s of %s" , origin, src);
@@ -203,7 +203,7 @@ static void shortlog(const char *name, u bol =strstr (commit->buffer,"\n\n" );if (!bol) { -append_to_list (&subjects,strdup (sha1_to_hex ( +append_to_list (&subjects,xstrdup (sha1_to_hex ( commit->object.sha1)),NULL );continue ;
@@ -218,7 +218,7 @@ static void shortlog(const char *name, umemcpy (oneline, bol, len); oneline[len] =0 ; }else - oneline =strdup (bol); + oneline =xstrdup (bol);append_to_list (&subjects, oneline,NULL ); }
@@ -277,7 +277,7 @@ int cmd_fmt_merge_msg(int argc, const chusage (fmt_merge_msg_usage);/* get current branch */ - head =strdup (git_path ("HEAD" )); + head =xstrdup (git_path ("HEAD" )); current_branch =resolve_ref (head, head_sha1,1 ); current_branch +=strlen (head) -4 ;free ((char *)head);
builtin-grep.c +1 -1
@@ -1048,7 +1048,7 @@ int cmd_grep(int argc, const char **argv/* ignore empty line like grep does */ if (!buf[0 ])continue ; -add_pattern (&opt,strdup (buf), argv[1 ], ++lno, +add_pattern (&opt,xstrdup (buf), argv[1 ], ++lno,GREP_PATTERN ); }fclose (patterns);
builtin-name-rev.c +1 -1
@@ -100,7 +100,7 @@ static int name_ref(const char *path, coelse if (!strncmp (path,"refs/" ,5 )) path = path +5 ; -name_rev (commit,strdup (path),0 ,0 , deref); +name_rev (commit,xstrdup (path),0 ,0 , deref); }return 0 ; }
builtin-prune.c +1 -1
@@ -106,7 +106,7 @@ static void process_tree(struct tree *tr obj->flags |=SEEN ;if (parse_tree (tree) <0 )die ("bad tree object %s" ,sha1_to_hex (obj->sha1)); - name =strdup (name); + name =xstrdup (name);add_object (obj, p, path, name); me.up = path; me.elem = name;
builtin-push.c +5 -5
@@ -33,7 +33,7 @@ static int expand_one_ref(const char *re ref +=5 ;if (!strncmp (ref,"tags/" ,5 )) -add_refspec (strdup (ref)); +add_refspec (xstrdup (ref));return 0 ; }
@@ -100,12 +100,12 @@ static int get_remotes_uri(const char *rif (!is_refspec) {if (n <MAX_URI ) - uri[n++] =strdup (s); + uri[n++] =xstrdup (s);else error ("more than %d URL's specified, ignoring the rest" ,MAX_URI ); }else if (is_refspec && !has_explicit_refspec) -add_refspec (strdup (s)); +add_refspec (xstrdup (s)); }fclose (f);if (!n)
@@ -125,13 +125,13 @@ static int get_remote_config(const char* !strncmp(key + 7, config_repo, config_repo_len)) {if (!strcmp (key +7 + config_repo_len,".url" )) {if (config_current_uri <MAX_URI ) - config_uri[config_current_uri++] =strdup (value); + config_uri[config_current_uri++] =xstrdup (value);else error ("more than %d URL's specified, ignoring the rest" ,MAX_URI ); }else if (config_get_refspecs && !strcmp (key +7 + config_repo_len,".push" )) -add_refspec (strdup (value)); +add_refspec (xstrdup (value)); }return 0 ; }
builtin-repo-config.c +3 -3
@@ -72,12 +72,12 @@ static int get_value(const char* key_, cconst char *home =getenv ("HOME" ); local =getenv ("GIT_CONFIG_LOCAL" );if (!local) - local = repo_config =strdup (git_path ("config" )); + local = repo_config =xstrdup (git_path ("config" ));if (home) - global =strdup (mkpath ("%s/.gitconfig" , home)); + global =xstrdup (mkpath ("%s/.gitconfig" , home)); } - key =strdup (key_); + key =xstrdup (key_);for (tl=key+strlen (key)-1 ; tl >= key && *tl !='.' ; --tl) *tl =tolower (*tl);for (tl=key; *tl && *tl !='.' ; ++tl)
builtin-rev-list.c +2 -2
@@ -109,7 +109,7 @@ static void process_blob(struct blob *blif (obj->flags & (UNINTERESTING |SEEN ))return ; obj->flags |=SEEN ; - name =strdup (name); + name =xstrdup (name);add_object (obj, p, path, name); }
@@ -130,7 +130,7 @@ static void process_tree(struct tree *trif (parse_tree (tree) <0 )die ("bad tree object %s" ,sha1_to_hex (obj->sha1)); obj->flags |=SEEN ; - name =strdup (name); + name =xstrdup (name);add_object (obj, p, path, name); me.up = path; me.elem = name;
builtin-rm.c +1 -1
@@ -32,7 +32,7 @@ static int remove_file(const char *name) ret =unlink (name);if (!ret && (slash =strrchr (name,'/' ))) { -char *n =strdup (name); +char *n =xstrdup (name); do { n[slash - name] = 0; name = n;
builtin-show-branch.c +3 -3
@@ -163,7 +163,7 @@ static void name_commits(struct commit_l en +=sprintf (en,"^" ); else en += sprintf(en, "^%d", nth); -name_commit (p,strdup (newname),0 ); +name_commit (p,xstrdup (newname),0 ); i++;name_first_parent_chain (p); }
@@ -364,7 +364,7 @@ static int append_ref(const char *refnam refname, MAX_REVS);return 0 ; } - ref_name[ref_name_cnt++] =strdup (refname); + ref_name[ref_name_cnt++] =xstrdup (refname); ref_name[ref_name_cnt] =NULL ;return 0 ; }
@@ -521,7 +521,7 @@ static int git_show_branch_config(const default_alloc = default_alloc *3 /2 +20 ; default_arg =xrealloc (default_arg,sizeof *default_arg * default_alloc); } - default_arg[default_num++] =strdup (value); + default_arg[default_num++] =xstrdup (value); default_arg[default_num] =NULL ;return 0 ; }
builtin-symbolic-ref.c +2 -2
@@ -7,7 +7,7 @@ static const char git_symbolic_ref_usagestatic void check_symref (const char *HEAD ) {unsigned char sha1[20 ]; -const char *git_HEAD =strdup (git_path ("%s" ,HEAD )); +const char *git_HEAD =xstrdup (git_path ("%s" ,HEAD ));const char *git_refs_heads_master =resolve_ref (git_HEAD, sha1,0 );if (git_refs_heads_master) {/* we want to strip the .git/ part */
@@ -26,7 +26,7 @@ int cmd_symbolic_ref(int argc, const chacheck_symref (argv[1 ]);break ;case 3 : -create_symref (strdup (git_path ("%s" , argv[1 ])), argv[2 ]); +create_symref (xstrdup (git_path ("%s" , argv[1 ])), argv[2 ]);break ;default :usage (git_symbolic_ref_usage);
builtin-tar-tree.c +1 -1
@@ -351,7 +351,7 @@ static int remote_tar(int argc, const chusage (tar_tree_usage);/* --remote=<repo> */ - url =strdup (argv[1 ]+9 ); + url =xstrdup (argv[1 ]+9 ); pid =git_connect (fd, url, exec);if (pid <0 )return 1 ;
builtin-upload-tar.c +1 -1
@@ -53,7 +53,7 @@ int cmd_upload_tar(int argc, const charreturn nak ("expected (optional) base" );if (buf[len-1 ] =='\n' ) buf[--len] =0 ; - base =strdup (buf +5 ); + base =xstrdup (buf +5 ); len =packet_read_line (0 , buf,sizeof (buf)); }if (len)
builtin-zip-tree.c +2 -2
@@ -311,11 +311,11 @@ int cmd_zip_tree(int argc, const char **switch (argc) {case 3 : - base =strdup (argv[2 ]); + base =xstrdup (argv[2 ]); baselen =strlen (base);break ;case 2 : - base =strdup ("" ); + base =xstrdup ("" ); baselen =0 ;break ;default :
commit.c +1 -1
@@ -233,7 +233,7 @@ static void prepare_commit_graft(void) }if (last_graft_file)free (last_graft_file); - last_graft_file =strdup (graft_file); + last_graft_file =xstrdup (graft_file);read_graft_file (graft_file); commit_graft_prepared =1 ;
config.c +4 -4
@@ -350,11 +350,11 @@ int git_config(config_fn_t fn) home =getenv ("HOME" ); filename =getenv ("GIT_CONFIG_LOCAL" );if (!filename) - filename = repo_config =strdup (git_path ("config" )); + filename = repo_config =xstrdup (git_path ("config" )); }if (home) { -char *user_config =strdup (mkpath ("%s/.gitconfig" , home)); +char *user_config =xstrdup (mkpath ("%s/.gitconfig" , home));if (!access (user_config,R_OK )) ret =git_config_from_file (fn, user_config);free (user_config);
@@ -545,8 +545,8 @@ int git_config_set_multivar(const char*if (!config_filename) config_filename =git_path ("config" ); } - config_filename =strdup (config_filename); - lock_file =strdup (mkpath ("%s.lock" , config_filename)); + config_filename =xstrdup (config_filename); + lock_file =xstrdup (mkpath ("%s.lock" , config_filename));/* * Since "key" actually contains the section name and the real
connect.c +3 -3
@@ -69,7 +69,7 @@ struct ref **get_remote_heads(int in, stif (len != name_len +41 ) {if (server_capabilities)free (server_capabilities); - server_capabilities =strdup (name + name_len +1 ); + server_capabilities =xstrdup (name + name_len +1 ); }if (!check_ref (name, name_len, flags))
@@ -661,7 +661,7 @@ int git_connect(int fd[2], char *url, coif (path[1 ] =='~' ) path++;else { - path =strdup (ptr); + path =xstrdup (ptr); free_path =1 ; }
@@ -672,7 +672,7 @@ int git_connect(int fd[2], char *url, co/* These underlying connection commands die() if they * cannot connect. */ -char *target_host =strdup (host); +char *target_host =xstrdup (host);if (git_use_proxy (host))git_proxy_connect (fd, host);else
diff.c +2 -2
@@ -216,7 +216,7 @@ static char *quote_one(const char *str)return NULL ; needlen =quote_c_style (str,NULL ,NULL ,0 );if (!needlen) -return strdup (str); +return xstrdup (str); xp =xmalloc (needlen +1 );quote_c_style (str, xp,NULL ,0 );return xp;
@@ -658,7 +658,7 @@ static struct diffstat_file *diffstat_ad x->is_renamed =1 ; }else - x->name =strdup (name_a); + x->name =xstrdup (name_a);return x; }
environment.c +1 -1
@@ -67,7 +67,7 @@ void setup_git(char *new_git_dir, char *free (git_graft_file); git_graft_file = new_git_graft_file;if (!git_graft_file) { - git_graft_file =strdup (git_path ("info/grafts" )); + git_graft_file =xstrdup (git_path ("info/grafts" )); dyn_git_graft_file =1 ; }else { dyn_git_graft_file =0 ;
fetch.c +2 -2
@@ -234,8 +234,8 @@ int pull_targets_stdin(char ***target, c *target =xrealloc (*target, targets_alloc *sizeof (**target)); *write_ref =xrealloc (*write_ref, targets_alloc *sizeof (**write_ref)); } - (*target)[targets] =strdup (tg_one); - (*write_ref)[targets] = rf_one ?strdup (rf_one) :NULL ; + (*target)[targets] =xstrdup (tg_one); + (*write_ref)[targets] = rf_one ?xstrdup (rf_one) :NULL ; targets++; }return targets;
fsck-objects.c +1 -1
@@ -458,7 +458,7 @@ static void fsck_object_dir(const char *static int fsck_head_link (void ) {unsigned char sha1[20 ]; -const char *git_HEAD =strdup (git_path ("HEAD" )); +const char *git_HEAD =xstrdup (git_path ("HEAD" ));const char *git_refs_heads_master =resolve_ref (git_HEAD, sha1,1 );int pfxlen =strlen (git_HEAD) -4 ;/* strip .../.git/ part */
git-compat-util.h +8 -0
@@ -84,6 +84,14 @@ #define strlcpy gitstrlcpyextern size_t gitstrlcpy (char *,const char *,size_t );#endif +static inline char *xstrdup (const char *str) +{ +char *ret =strdup (str); +if (!ret) +die ("Out of memory, strdup failed" ); +return ret; +} +static inline void *xmalloc (size_t size) {void *ret =malloc (size);
git.c +1 -1
@@ -97,7 +97,7 @@ static char *alias_string;static int git_alias_config (const char *var,const char *value) {if (!strncmp (var,"alias." ,6 ) && !strcmp (var +6 , alias_command)) { - alias_string =strdup (value); + alias_string =xstrdup (value); }return 0 ; }
http-fetch.c +1 -1
@@ -787,7 +787,7 @@ static int remote_ls(struct alt_base *re ls.flags = flags; ls.repo = repo; - ls.path =strdup (path); + ls.path =xstrdup (path); ls.dentry_name =NULL ; ls.dentry_flags =0 ; ls.userData = userData;
http-push.c +3 -3
@@ -1539,7 +1539,7 @@ static void remote_ls(const char *path,struct remote_ls_ctx ls; ls.flags = flags; - ls.path =strdup (path); + ls.path =xstrdup (path); ls.dentry_name =NULL ; ls.dentry_flags =0 ; ls.userData = userData;
@@ -1738,7 +1738,7 @@ static struct object_list **process_treedie ("bad tree object %s" ,sha1_to_hex (obj->sha1)); obj->flags |=SEEN ; - name =strdup (name); + name =xstrdup (name); p =add_one_object (obj, p); me.up = path; me.elem = name;
@@ -2467,7 +2467,7 @@ int main(int argc, char **argv)/* Set up revision info for this refspec */ commit_argc =3 ; - new_sha1_hex =strdup (sha1_to_hex (ref->new_sha1)); + new_sha1_hex =xstrdup (sha1_to_hex (ref->new_sha1)); old_sha1_hex =NULL ; commit_argv[1 ] ="--objects" ; commit_argv[2 ] = new_sha1_hex;
imap-send.c +6 -6
@@ -1007,7 +1007,7 @@ imap_open_store( imap_server_conf_t *srv* getpass() returns a pointer to a static buffer. make a copy * for long term storage. */ - srvc->pass =strdup ( arg ); + srvc->pass =xstrdup ( arg ); }if (CAP (NOLOGIN )) {fprintf ( stderr,"Skipping account %s@%s, server forbids LOGIN\n" , srvc->user, srvc->host );
@@ -1263,7 +1263,7 @@ git_imap_config(const char *key, const c key +=sizeof imap_key -1 ;if (!strcmp ("folder" , key )) { - imap_folder =strdup ( val ); + imap_folder =xstrdup ( val ); }else if (!strcmp ("host" , key )) { {if (!strncmp ("imap:" , val,5 ))
@@ -1273,16 +1273,16 @@ git_imap_config(const char *key, const c }if (!strncmp ("//" , val,2 )) val +=2 ; - server.host =strdup ( val ); + server.host =xstrdup ( val ); }else if (!strcmp ("user" , key )) - server.user =strdup ( val ); + server.user =xstrdup ( val );else if (!strcmp ("pass" , key )) - server.pass =strdup ( val ); + server.pass =xstrdup ( val );else if (!strcmp ("port" , key )) server.port =git_config_int ( key, val );else if (!strcmp ("tunnel" , key )) - server.tunnel =strdup ( val ); + server.tunnel =xstrdup ( val );return 0 ; }
merge-file.c +1 -1
@@ -21,7 +21,7 @@ static const char *write_temp_file(mmfil fd =mkstemp (filename);if (fd <0 )return NULL ; - filename =strdup (filename); + filename =xstrdup (filename);if (f->size !=xwrite (fd, f->ptr, f->size)) {rm_temp_file (filename);return NULL ;
merge-recursive.c +7 -7
@@ -513,8 +513,8 @@ static char *unique_path(const char *patstatic int mkdir_p (const char *path,unsigned long mode) { -/* path points to cache entries, so strdup before messing with it */ -char *buf =strdup (path); +/* path points to cache entries, so xstrdup before messing with it */ +char *buf =xstrdup (path);int result =safe_create_leading_directories (buf);free (buf);return result;
@@ -668,9 +668,9 @@ static struct merge_file_info merge_filegit_unpack_file (a->sha1, src1);git_unpack_file (b->sha1, src2); - argv[2 ] = la =strdup (mkpath ("%s/%s" , branch1, a->path)); - argv[6 ] = lb =strdup (mkpath ("%s/%s" , branch2, b->path)); - argv[4 ] = lo =strdup (mkpath ("orig/%s" , o->path)); + argv[2 ] = la =xstrdup (mkpath ("%s/%s" , branch1, a->path)); + argv[6 ] = lb =xstrdup (mkpath ("%s/%s" , branch2, b->path)); + argv[4 ] = lo =xstrdup (mkpath ("orig/%s" , o->path)); argv[7 ] = src1; argv[8 ] = orig; argv[9] = src2,
@@ -1314,9 +1314,9 @@ int main(int argc, char *argv[]) original_index_file =getenv ("GIT_INDEX_FILE" );if (!original_index_file) - original_index_file =strdup (git_path ("index" )); + original_index_file =xstrdup (git_path ("index" )); - temporary_index_file =strdup (git_path ("mrg-rcrsv-tmp-idx" )); + temporary_index_file =xstrdup (git_path ("mrg-rcrsv-tmp-idx" ));if (argc <4 )die ("Usage: %s <base>... -- <head> <remote> ...\n" , argv[0 ]);
merge-tree.c +2 -2
@@ -177,7 +177,7 @@ static void resolve(const char *base, stif (!branch1)return ; - path =strdup (mkpath ("%s%s" , base, result->path)); + path =xstrdup (mkpath ("%s%s" , base, result->path)); orig =create_entry (2 , branch1->mode, branch1->sha1, path); final =create_entry (0 , result->mode, result->sha1, path);
@@ -233,7 +233,7 @@ static struct merge_list *link_entry(unsif (entry) path = entry->path;else - path =strdup (mkpath ("%s%s" , base, n->path)); + path =xstrdup (mkpath ("%s%s" , base, n->path)); link =create_entry (stage, n->mode, n->sha1, path); link->link = entry;return link;
path-list.c +1 -1
@@ -45,7 +45,7 @@ static int add_entry(struct path_list *l (list->nr - index) * sizeof(struct path_list_item)); list->items[index].path = list->strdup_paths ? -strdup (path) : (char *)path; +xstrdup (path) : (char *)path; list->items[index].util =NULL ; list->nr++;
refs.c +2 -2
@@ -313,8 +313,8 @@ static struct ref_lock *lock_ref_sha1_ba } lock->lk =xcalloc (1 ,sizeof (struct lock_file )); - lock->ref_file =strdup (path); - lock->log_file =strdup (git_path ("logs/%s" , lock->ref_file + plen)); + lock->ref_file =xstrdup (path); + lock->log_file =xstrdup (git_path ("logs/%s" , lock->ref_file + plen)); lock->force_write =lstat (lock->ref_file, &st) && errno ==ENOENT ;if (safe_create_leading_directories (lock->ref_file))
server-info.c +1 -1
@@ -23,7 +23,7 @@ static int add_info_ref(const char *pathstatic int update_info_refs (int force) { -char *path0 =strdup (git_path ("info/refs" )); +char *path0 =xstrdup (git_path ("info/refs" ));int len =strlen (path0);char *path1 =xmalloc (len +2 );
sha1_file.c +4 -4
@@ -115,7 +115,7 @@ static void fill_sha1_path(char *pathbuf/* * NOTE! This returns a statically allocated buffer, so you have to be -* careful about using it. Do a "strdup()" if you need to save the +* careful about using it. Do a "xstrdup()" if you need to save the * filename. * * Also note that this returns the location for creating. Reading
@@ -141,7 +141,7 @@ char *sha1_file_name(const unsigned char name = base + len +1 ;if (last_objdir)free ((char *) last_objdir); - last_objdir =strdup (sha1_file_directory); + last_objdir =xstrdup (sha1_file_directory); }fill_sha1_path (name, sha1);return base;
@@ -164,7 +164,7 @@ char *sha1_pack_name(const unsigned char name = base + len +11 ;if (last_objdir)free ((char *) last_objdir); - last_objdir =strdup (sha1_file_directory); + last_objdir =xstrdup (sha1_file_directory); } buf = name;
@@ -195,7 +195,7 @@ char *sha1_pack_index_name(const unsigne name = base + len +11 ;if (last_objdir)free ((char *) last_objdir); - last_objdir =strdup (sha1_file_directory); + last_objdir =xstrdup (sha1_file_directory); } buf = name;
sha1_name.c +2 -2
@@ -26,7 +26,7 @@ static int find_short_object_filename(in fakeent->name[-1 ] ='/' ;if (last_objdir)free ((char *) last_objdir); - last_objdir =strdup (objdir); + last_objdir =xstrdup (objdir); } fakeent->next = alt_odb_list;
@@ -285,7 +285,7 @@ static int get_sha1_basic(const char *st pathname =resolve_ref (git_path (*p, len, str), this_result,1 );if (pathname) {if (!refs_found++) - real_path =strdup (pathname); + real_path =xstrdup (pathname);if (!warn_ambiguous_refs)break ; }
Signature · 5 lines
1.4.2.ga2654 -- VGER BF report: U 0.5