fix possible NULL ptr deref in forcedeth
PATCH 1/1 fix possible NULL ptr deref in forcedeth
There seems to be a possible NULL pointer deref bug in drivers/net/forcedeth.c::nv_loopback_test().
If dev_alloc_skb() fails, the next line will call skb_put() with a NULL first argument which it'll then try to deref -
kaboom: a NULL pointer deref.
Found by coverity (#1337).
Signed-off-by Jesper Juhl <[email protected]>
---
drivers/net/forcedeth.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletion(-)
drivers/net/forcedeth.c +7 -1
@@ -3656,6 +3656,12 @@ static int nv_loopback_test(struct net_d/* setup packet for tx */ pkt_len =ETH_DATA_LEN ; tx_skb =dev_alloc_skb (pkt_len); +if (!tx_skb) { +printk (KERN_ERR "dev_alloc_skb() failed during loopback test" +" of %s\n" , dev->name); + ret =0 ; + goto out; + } pkt_data =skb_put (tx_skb, pkt_len);for (i =0 ; i < pkt_len; i++) pkt_data[i] = (u8)(i &0xff );
@@ -3720,7 +3726,7 @@ static int nv_loopback_test(struct net_d tx_skb->end-tx_skb->data, PCI_DMA_TODEVICE);dev_kfree_skb_any (tx_skb); - + out:/* stop engines */ nv_stop_rx (dev);nv_stop_tx (dev);
Signature · 1 line
VGER BF report: U 0.499932