Skip to contentSkip to conversation

Missing initialization in common i/o layer.

S390 Martin Schwidefsky 1 participant 1 message Sep 4, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Heiko Carstens <[email protected]>

[S390] Missing initialization in common i/o layer.

Previous patch that was intended to reduce stack usage within common i/o layer didn't consider implicit memset(..., 0, ...) used with the initializations used before.
Add these missing memsets wherever it's not obvious that the concerned memory region is zeroed. This should give the same semantics as before.

---

 drivers/s390/cio/device_fsm.c |    1 +
 1 files changed, 1 insertion(+)
drivers/s390/cio/device_fsm.c +1 -0
diff -urpN linux-2.6/drivers/s390/cio/device_fsm.c linux-2.6-patched/drivers/s390/cio/device_fsm.c
@@ -267,6 +267,7 @@ ccw_device_recog_done(struct ccw_device 
 			notify = 1;
 		}
 		/* fill out sense information */
+		memset(&cdev->id, 0, sizeof(cdev->id));
 		cdev->id.cu_type   = cdev->private->senseid.cu_type;
 		cdev->id.cu_model  = cdev->private->senseid.cu_model;
 		cdev->id.dev_type  = cdev->private->senseid.dev_type;
Signature · 1 line
VGER BF report: U 0.495386