Subject: Re: [PATCH] Kcore elf note namesz field fix
In-Reply-To: <[email protected]>
X-Newsgroups: gmane.linux.kernel,gmane.comp.boot-loaders.fastboot.general
Quoted 8 lines · Vivek Goyal
o As per ELF specifications, it looks like that elf note "namesz" field contains the length of "name" including the size of null character. And currently we are filling "namesz" without taking into the consideration the null character size.
Quoted 4 lines
o Kexec-tools performs this check deligently hence I ran into the issue while trying to open
/proc/kcorein kexec-tools for some info.Signed-off-by Vivek Goyal <[email protected]>
That is in keeping with my reading of pages 2-4 and 2-5 of version 1.1 of the specification (is there a later version?)
Acked: Simon Horman <[email protected]>
Quoted 27 lines
---
fs/proc/kcore.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)diff -puN
fs/proc/kcore.c~kcore-elf-note-namesz-fixfs/proc/kcore.cfs/proc/kcore.c renamed from fs/proc/kcore.c~kcore-elf-note-namesz-fix +2
-2@@ -100,7 +100,7 @@ static int notesize(struct memelfnote *eint sz; sz =sizeof (struct elf_note ); - sz +=roundup (strlen (en->name),4 ); + sz +=roundup ((strlen (en->name) +1 ),4 ); sz +=roundup (en->datasz,4 );return sz;@@ -116,7 +116,7 @@ static char *storenote(struct memelfnote#define DUMP_WRITE (addr,nr) do { memcpy(bufp,addr,nr); bufp += nr; } while(0) - en.n_namesz =strlen (men->name); + en.n_namesz =strlen (men->name) +1 ; en.n_descsz = men->datasz; en.n_type = men->type;_