Skip to contentSkip to conversation

PCI: sort device lists breadth-first

PATCH New Ragnar Kjørstad 1 participant 1 message Sep 9, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: sort device lists breadth-first

[ I'm not subscribed. Please CC me on replies ]

Quoted 9 lines

Solution:

The solution can come in multiple steps.

Suggested fix #1: kernel
Patch below sorts the two device lists into breadth-first ordering to maintain compatibility with 2.4 kernels. It also overloads the 'pci=nosort' option to disable the breadth-first sort (and on i386 it continues to disable the pcibios_find_device sort as well).

As far as I understand it's difficult to argue that sorting the devices one way is more "correct" than the other, so your argument is basically:
1) Compability with 2.4
2) Consistency with BIOS and external labels.

Both are important, but the problem is
1) Compability with 2.4 means breaking compability with previous 2.6 kernels. And 2.6 has been out long enough that it's more important than 2.4.
2) There is also hardware where the 2.6 behaviour is consistent with BIOS and external labels where 2.4 is not.

An _option_ to enable 2.4 compatible device ordering on the other hand would have just advantages, no disadvantages.

Signature · 4 lines
Ragnar Kjørstad
Software Engineer
Scali - http://www.scali.com
Scaling the Linux Datacenter