Skip to contentSkip to conversation

kdump: kdump_disable_iosapic needs CONFIG_IOSAPIC

PATCH New Horms 1 participant 2 messages Sep 15, 2006

lore
Share & tools
lore

Horms

author
#0 lore raw

PATCH 1/1 kdump: kdump_disable_iosapic needs CONFIG_IOSAPIC

Hi Nanhai,

here is a minor patch against your lastest ia64 kexec patch. kdump_disable_iosapic() doesn't exist without CONFIG_IOSAPIC, calling it needs to be gaurded by a corresponding #ifdef

arch/ia64/kernel/crash.c +2 -0
index aa63c47..e15e15d 100644
@@ -42,7 +42,9 @@ size_t copy_oldmem_page(unsigned long pf
 
 static void device_shootdown(void)
 {
+#ifdef CONFIG_IOSAPIC
 	kdump_disable_iosapic();
+#endif
 #ifdef CONFIG_IA64_HP_ZX1
 	ioc_iova_disable();
 #endif
author
#1 lore raw

PATCH 1/1 kdump: kdump_disable_iosapic needs CONFIG_KEXEC

Hi Nanhai,

Currently kdump_disable_iosapic is gaurded by CONFIG_CRASH_DUMP, however it is run buy the crashing kernel, not the crash kernel, and thus needs to be present for CONFIG_KEXEC, not CONFIG_CRASH_DUMP.

arch/ia64/kernel/iosapic.c +1 -1
index 9e9367a..2f58502 100644
@@ -288,7 +288,7 @@ nop (unsigned int irq)
 	/* do nothing... */
 }
 
-#ifdef CONFIG_CRASH_DUMP
+#ifdef CONFIG_KEXEC
 void
 kdump_disable_iosapic(void)
 {