mptspi : min_period, max_offset, max_width, incorrectly set, resulting domain validation failing
Subsystems (2)
PATCH 1/1 mptspi : min_period, max_offset, max_width, incorrectly set, resulting domain validation failing
The default nego parameters are only usign values from NVRAM, which is incorrect. Typically you will find the NVRAM parameters set for U320 speeds, even when all the devices are U160.
Thus its possible for the spi transport layer to try negotiating devices at a faster speed than it can support. In some cases, devices can not handle faster negoiation, and will never complete the command invoking scsi-mid layer error handling, or worse, hang the bus.
This patch will look at inquiry data, and determing the maximum nego a device
can handle. We still take into account the NVRAM settings. The
three routines that interpret the inquiry data for domain validation, are moved over from mptscish.c to mptspi.c; and spi_min_period, spi_max_offset, and spi_max_width are set from mptspi_setTargetNegoParms.
drivers/message/fusion/mptscsih.c +0 -287
@@ -135,9 +135,6 @@ static int mptscsih_IssueTaskMgmt(MPT_SCint mptscsih_ioc_reset (MPT_ADAPTER *ioc,int post_reset);int mptscsih_event_process (MPT_ADAPTER *ioc,EventNotificationReply_t *pEvReply); -static void mptscsih_initTarget (MPT_SCSI_HOST *hd,VirtTarget *vtarget,struct scsi_device *sdev); -static void mptscsih_setTargetNegoParms (MPT_SCSI_HOST *hd,VirtTarget *vtarget,struct scsi_device *sdev); -static int mptscsih_writeIOCPage4 (MPT_SCSI_HOST *hd,int target_id,int bus);int mptscsih_scandv_complete (MPT_ADAPTER *ioc,MPT_FRAME_HDR *mf,MPT_FRAME_HDR *r);static int mptscsih_do_cmd (MPT_SCSI_HOST *hd,INTERNAL_CMD *iocmd);static void mptscsih_synchronize_cache (MPT_SCSI_HOST *hd,VirtDevice *vdevice);
@@ -2408,7 +2405,6 @@ mptscsih_slave_configure(struct scsi_dev lun_index = (vdevice->lun >>5 );/* 32 luns per lun_index */ indexed_lun = (vdevice->lun %32 ); vtarget->luns[lun_index] |= (1 << indexed_lun); -mptscsih_initTarget (hd, vtarget, sdev);mptscsih_change_queue_depth (sdev,MPT_SCSI_CMD_PER_DEV_HIGH ); dsprintk((MYIOC_s_INFO_FMT
@@ -2672,289 +2668,6 @@ mptscsih_event_process(MPT_ADAPTER *ioc,/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ /* -* mptscsih_initTarget - Target, LUN alloc/free functionality. -* @hd: Pointer to MPT_SCSI_HOST structure -* @vtarget: per target private data -* @sdev: SCSI device -* -* NOTE: It's only SAFE to call this routine if data points to -* sane & valid STANDARD INQUIRY data! -* -* Allocate and initialize memory for this target. -* Save inquiry data. -* -*/ -static void -mptscsih_initTarget (MPT_SCSI_HOST *hd,VirtTarget *vtarget, -struct scsi_device *sdev) -{ -dinitprintk ((MYIOC_s_INFO_FMT"initTarget bus=%d id=%d lun=%d hd=%p\n" , - hd->ioc->name, vtarget->bus_id, vtarget->target_id, lun, hd)); - -/* Is LUN supported? If so, upper 2 bits will be 0 -* in first byte of inquiry data. -*/ -if (sdev->inq_periph_qual !=0 ) -return ; - -if (vtarget ==NULL ) -return ; - - vtarget->type = sdev->type; - -if (hd->ioc->bus_type !=SPI ) -return ; - -if ((sdev->type ==TYPE_PROCESSOR ) && (hd->ioc->spi_data.Saf_Te)) { -/* Treat all Processors as SAF-TE if -* command line option is set */ - vtarget->tflags |=MPT_TARGET_FLAGS_SAF_TE_ISSUED ; -mptscsih_writeIOCPage4 (hd, vtarget->target_id, vtarget->bus_id); - }else if ((sdev->type ==TYPE_PROCESSOR ) && - !(vtarget->tflags &MPT_TARGET_FLAGS_SAF_TE_ISSUED )) { -if (sdev->inquiry_len >49 ) { -if (sdev->inquiry[44 ] =='S' && - sdev->inquiry[45 ] =='A' && - sdev->inquiry[46 ] =='F' && - sdev->inquiry[47 ] =='-' && - sdev->inquiry[48 ] =='T' && - sdev->inquiry[49 ] =='E' ) { - vtarget->tflags |=MPT_TARGET_FLAGS_SAF_TE_ISSUED ; -mptscsih_writeIOCPage4 (hd, vtarget->target_id, vtarget->bus_id); - } - } - } -mptscsih_setTargetNegoParms (hd, vtarget, sdev); -} - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -/* -* Update the target negotiation parameters based on the -* the Inquiry data, adapter capabilities, and NVRAM settings. -* -*/ -static void -mptscsih_setTargetNegoParms (MPT_SCSI_HOST *hd,VirtTarget *target, -struct scsi_device *sdev) -{ -SpiCfgData *pspi_data = &hd->ioc->spi_data; -int id = (int ) target->target_id; -int nvram; -u8 width =MPT_NARROW ; -u8 factor =MPT_ASYNC ; -u8 offset =0 ; -u8 nfactor; -u8 noQas =1 ; - - target->negoFlags = pspi_data->noQas; - -/* noQas == 0 => device supports QAS. */ - -if (sdev->scsi_level <SCSI_2 ) { - width =0 ; - factor =MPT_ULTRA2 ; - offset = pspi_data->maxSyncOffset; - target->tflags &= ~MPT_TARGET_FLAGS_Q_YES ; - }else { -if (scsi_device_wide (sdev)) { - width =1 ; - } - -if (scsi_device_sync (sdev)) { - factor = pspi_data->minSyncFactor; -if (!scsi_device_dt (sdev)) - factor =MPT_ULTRA2 ; -else { -if (!scsi_device_ius (sdev) && - !scsi_device_qas (sdev)) - factor =MPT_ULTRA160 ; -else { - factor =MPT_ULTRA320 ; -if (scsi_device_qas (sdev)) { -ddvtprintk ((KERN_INFO "Enabling QAS due to byte56=%02x on id=%d!\n" , byte56, id)); - noQas =0 ; - } -if (sdev->type ==TYPE_TAPE && -scsi_device_ius (sdev)) - target->negoFlags |=MPT_TAPE_NEGO_IDP ; - } - } - offset = pspi_data->maxSyncOffset; - -/* If RAID, never disable QAS -* else if non RAID, do not disable -* QAS if bit 1 is set -* bit 1 QAS support, non-raid only -* bit 0 IU support -*/ -if (target->raidVolume ==1 ) { - noQas =0 ; - } - }else { - factor =MPT_ASYNC ; - offset =0 ; - } - } - -if (!sdev->tagged_supported) { - target->tflags &= ~MPT_TARGET_FLAGS_Q_YES ; - } - -/* Update tflags based on NVRAM settings. (SCSI only) -*/ -if (pspi_data->nvram && (pspi_data->nvram[id] !=MPT_HOST_NVRAM_INVALID )) { - nvram = pspi_data->nvram[id]; - nfactor = (nvram &MPT_NVRAM_SYNC_MASK ) >>8 ; - -if (width) - width = nvram &MPT_NVRAM_WIDE_DISABLE ?0 :1 ; - -if (offset >0 ) { -/* Ensure factor is set to the -* maximum of: adapter, nvram, inquiry -*/ -if (nfactor) { -if (nfactor < pspi_data->minSyncFactor ) - nfactor = pspi_data->minSyncFactor; - - factor =max (factor, nfactor); -if (factor ==MPT_ASYNC ) - offset =0 ; - }else { - offset =0 ; - factor =MPT_ASYNC ; - } - }else { - factor =MPT_ASYNC ; - } - } - -/* Make sure data is consistent -*/ -if ((!width) && (factor <MPT_ULTRA2 )) { - factor =MPT_ULTRA2 ; - } - -/* Save the data to the target structure. -*/ - target->minSyncFactor = factor; - target->maxOffset = offset; - target->maxWidth = width; - - target->tflags |=MPT_TARGET_FLAGS_VALID_NEGO ; - -/* Disable unused features. -*/ -if (!width) - target->negoFlags |=MPT_TARGET_NO_NEGO_WIDE ; - -if (!offset) - target->negoFlags |=MPT_TARGET_NO_NEGO_SYNC ; - -if ( factor >MPT_ULTRA320 ) - noQas =0 ; - -if (noQas && (pspi_data->noQas ==0 )) { - pspi_data->noQas |=MPT_TARGET_NO_NEGO_QAS ; - target->negoFlags |=MPT_TARGET_NO_NEGO_QAS ; - -/* Disable QAS in a mixed configuration case -*/ - -ddvtprintk ((KERN_INFO "Disabling QAS due to noQas=%02x on id=%d!\n" , noQas, id)); - } -} - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -/* -* SCSI Config Page functionality ... -*/ - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -/* mptscsih_writeIOCPage4 - write IOC Page 4 -* @hd: Pointer to a SCSI Host Structure -* @target_id: write IOC Page4 for this ID & Bus -* -* Return: -EAGAIN if unable to obtain a Message Frame -* or 0 if success. -* -* Remark: We do not wait for a return, write pages sequentially. -*/ -static int -mptscsih_writeIOCPage4 (MPT_SCSI_HOST *hd,int target_id,int bus) -{ -MPT_ADAPTER *ioc = hd->ioc; -Config_t *pReq; -IOCPage4_t *IOCPage4Ptr; -MPT_FRAME_HDR *mf; -dma_addr_t dataDma; -u16 req_idx; -u32 frameOffset; -u32 flagsLength; -int ii; - -/* Get a MF for this command. -*/ -if ((mf =mpt_get_msg_frame (ioc->DoneCtx, ioc)) ==NULL ) { -dfailprintk ((MYIOC_s_WARN_FMT"writeIOCPage4 : no msg frames!\n" , - ioc->name)); -return -EAGAIN ; - } - -/* Set the request and the data pointers. -* Place data at end of MF. -*/ - pReq = (Config_t *)mf; - - req_idx =le16_to_cpu (mf->u.frame.hwhdr.msgctxu.fld.req_idx); - frameOffset = ioc->req_sz -sizeof (IOCPage4_t); - -/* Complete the request frame (same for all requests). -*/ - pReq->Action =MPI_CONFIG_ACTION_PAGE_WRITE_CURRENT ; - pReq->Reserved =0 ; - pReq->ChainOffset =0 ; - pReq->Function =MPI_FUNCTION_CONFIG ; - pReq->ExtPageLength =0 ; - pReq->ExtPageType =0 ; - pReq->MsgFlags =0 ; -for (ii=0 ; ii <8 ; ii++) { - pReq->Reserved2[ii] =0 ; - } - - IOCPage4Ptr = ioc->spi_data.pIocPg4; - dataDma = ioc->spi_data.IocPg4_dma; - ii = IOCPage4Ptr->ActiveSEP++; - IOCPage4Ptr->SEP[ii].SEPTargetID = target_id; - IOCPage4Ptr->SEP[ii].SEPBus = bus; - pReq->Header = IOCPage4Ptr->Header; - pReq->PageAddress =cpu_to_le32 (target_id | (bus <<8 )); - -/* Add a SGE to the config request. -*/ - flagsLength =MPT_SGE_FLAGS_SSIMPLE_WRITE | - (IOCPage4Ptr->Header.PageLength + ii) *4 ; - -mpt_add_sge ((char *)&pReq->PageBufferSGE, flagsLength, dataDma); - -dinitprintk ((MYIOC_s_INFO_FMT -"writeIOCPage4: MaxSEP=%d ActiveSEP=%d id=%d bus=%d\n" , - ioc->name, IOCPage4Ptr->MaxSEP, IOCPage4Ptr->ActiveSEP, target_id, bus)); - -mpt_put_msg_frame (ioc->DoneCtx, ioc, mf); - -return 0 ; -} - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -/* -* Bus Scan and Domain Validation functionality ... -*/ - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -/* * mptscsih_scandv_complete - Scan and DV callback routine registered * to Fustion MPT (base) driver. *
drivers/message/fusion/mptspi.c +268 -1
287 lines not on this page · raw message
Quoted 8 lines · Eric Moore
The default nego parameters are only usign values from NVRAM, which is incorrect. Typically you will find the NVRAM parameters set for U320 speeds, even when all the devices are U160. Thus its possible for the spi transport layer to try negotiating devices at a faster speed than it can support. In some cases, devices can not handle faster negoiation, and will never complete the command invoking scsi-mid layer error handling, or worse, hang the bus.
This analysis doesn't quit sound correct to me. The SPI layer is designed to use all the inquiry parameters to determine the max settings. We ignore anything the driver has done (in fact, we really expect that before DV begins the device should be narrow async).
These heuristics, by the way, have been tweaked to try to avoid taking devices through known problematic states (such as PPR negotiation on an non-LVD bus).
Quoted 7 lines
This patch will look at inquiry data, and determing the maximum nego a device
can handle. We still take into account the NVRAM settings. The
three routines that interpret the inquiry data for domain validation, are moved over frommptscish.ctomptspi.c; andspi_min_period,spi_max_offset, andspi_max_widthare set frommptspi_setTargetNegoParms.
All of this should be done already in the generic code ... it knows full well that the min and max taken from the BIOS are likely "overoptimistic" so it doesn't begin with them as the negotiation ... it begins with whatever the device can support from its inquiry data and then reduces these so as not to go over/under the min/max settings
Can you post the problem you're actually having? If there's a negotiation problem in the SPI transport class, it's likely not specific to the mptspi driver.
James