Skip to contentSkip to conversation

driver core fixes: bus_add_attrs() retval check

PATCH In review Cornelia Huck 1 participant 1 message Sep 22, 2006 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 4/9 driver core fixes: bus_add_attrs() retval check

From: Cornelia Huck <[email protected]>

Check return value of bus_add_attrs() in bus_register().

---
 drivers/base/bus.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/base/bus.c +5 -1
@@ -746,11 +746,15 @@ int bus_register(struct bus_type * bus)
 
 	klist_init(&bus->klist_devices, klist_devices_get, klist_devices_put);
 	klist_init(&bus->klist_drivers, NULL, NULL);
-	bus_add_attrs(bus);
+	retval = bus_add_attrs(bus);
+	if (retval)
+		goto bus_attrs_fail;
 
 	pr_debug("bus type '%s' registered\n", bus->name);
 	return 0;
 
+bus_attrs_fail:
+	kset_unregister(&bus->drivers);
 bus_drivers_fail:
 	kset_unregister(&bus->devices);
 bus_devices_fail: