Skip to contentSkip to conversation

memcpy_fromio() missing in istallion

PATCH In review Al Viro 2 participants 2 messages Sep 23, 2006 Char and misc drivers

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 memcpy_fromio() missing in istallion

memcpy() from iomem is a bad thing...

---
 drivers/char/istallion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
index 84dfc42..8c09997 100644
@@ -3488,7 +3488,7 @@ static int stli_initecp(stlibrd_t *brdp)
  */
 	EBRDENABLE(brdp);
 	sigsp = (cdkecpsig_t __iomem *) EBRDGETMEMPTR(brdp, CDK_SIGADDR);
-	memcpy(&sig, sigsp, sizeof(cdkecpsig_t));
+	memcpy_fromio(&sig, sigsp, sizeof(cdkecpsig_t));
 	EBRDDISABLE(brdp);
 
 	if (sig.magic != cpu_to_le32(ECP_MAGIC))
Signature · 1 line
1.4.2.GIT