memcpy_fromio() missing in istallion
PATCH 1/1 memcpy_fromio() missing in istallion
memcpy() from iomem is a bad thing...
Signed-off-by Al Viro <[email protected]>
--- drivers/char/istallion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
@@ -3488,7 +3488,7 @@ static int stli_initecp(stlibrd_t *brdp)*/ EBRDENABLE (brdp); sigsp = (cdkecpsig_t __iomem *)EBRDGETMEMPTR (brdp,CDK_SIGADDR ); -memcpy (&sig, sigsp,sizeof (cdkecpsig_t)); +memcpy_fromio (&sig, sigsp,sizeof (cdkecpsig_t));EBRDDISABLE (brdp);if (sig.magic !=cpu_to_le32 (ECP_MAGIC ))
Signature · 1 line
1.4.2.GIT
Ar Sad, 2006-09-23 am 01:20 +0100, ysgrifennodd Al Viro:
Quoted 3 lines
memcpy()from iomem is a bad thing...Signed-off-by Al Viro <[email protected]>
Acked-by Alan Cox <[email protected]>