Skip to contentSkip to conversation

restore __iomem annotations in e1000

PATCH Applied Al Viro 3 participants 5 messages Sep 23, 2006 – Sep 26, 2006 Network drivers

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 restore __iomem annotations in e1000

---
 drivers/net/e1000/e1000_hw.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/e1000/e1000_hw.h +2 -2
index 375b955..a7e3a82 100644
@@ -1365,8 +1365,8 @@ struct e1000_hw_stats {
 
 /* Structure containing variables used by the shared code (e1000_hw.c) */
 struct e1000_hw {
-    uint8_t *hw_addr;
-    uint8_t *flash_address;
+    uint8_t __iomem *hw_addr;
+    uint8_t __iomem *flash_address;
     e1000_mac_type mac_type;
     e1000_phy_type phy_type;
     uint32_t phy_init_script;
Signature · 1 line
1.4.2.GIT
#2 lore raw
Quoted 2 lines · Jeff Garzik

applied

Thanks,

I have no idea why and when these annotations were lost, but we have them in much older versions of the code. I'll try to track it down and make sure that it doesn't disappear again.

Cheers,

Auke

#3 lore raw
Quoted 7 lines · Auke Kok
Quoted 2 lines · Jeff Garzik

applied

Thanks,

I have no idea why and when these annotations were lost, but we have them in much older versions of the code. I'll try to track it down and make sure that it doesn't disappear again.

Just run an sparse check as described in
Documentation/sparse.txt...

Jeff

#4 lore raw
Quoted 11 lines · Jeff Garzik
Quoted 7 lines · Auke Kok
Quoted 2 lines · Jeff Garzik

applied

Thanks,

I have no idea why and when these annotations were lost, but we have them in much older versions of the code. I'll try to track it down and make sure that it doesn't disappear again.

Just run an sparse check as described in
Documentation/sparse.txt...

gotcha, I'll try to do this on a regular basis.

Thanks,

Auke