Skip to contentSkip to conversation

wrong thing iounmapped (qla3xxx)

PATCH New Al Viro 1 participant 1 message Sep 25, 2006 Network drivers

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 wrong thing iounmapped (qla3xxx)

ql3xxx_probe() does ioremap and stores result in ->mem_map_registers. On failure exit it does iounmap() of the same thing. OTOH, ql3xxx_remove() does iounmap() of ->mmap_virt_base which is (a) never assigned and
(b) never used other than in that iounmap() call.

---
 drivers/net/qla3xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/qla3xxx.c +1 -1
index c184cd8..1574718 100644
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(stru
 		qdev->workqueue = NULL;
 	}
 
-	iounmap(qdev->mmap_virt_base);
+	iounmap(qdev->mem_map_registers);
 	pci_release_regions(pdev);
 	pci_set_drvdata(pdev, NULL);
 	free_netdev(ndev);
Signature · 1 line
1.4.2.GIT