Skip to contentSkip to conversation

mainline aic94xx firmware woes

DISCUSSION Muli Ben-Yehuda 6 participants 8 messages Sep 25, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

Hi,

The recently merged aic94xx in mainline requires external firmware support. This, in turn, necessitates an initrd/initramfs environment that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it, or FW_LOADER providing empty request_firmware() in case it's compiled out (the last one violates the principle of least surprise IMHO).

Cheers,
Muli

#1 lore raw
Quoted 8 lines · Muli Ben-Yehuda

Hi,

The recently merged aic94xx in mainline requires external firmware support. This, in turn, necessitates an initrd/initramfs environment that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

It's not my call, but I'd say that if the firmware is not GPL and the source for that firmware is not available then the answer will be NO (which would also be my personal opinion btw).

Quoted 6 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it, or FW_LOADER providing empty request_firmware() in case it's compiled out (the last one violates the principle of least surprise IMHO).

I'd say aic94xx depending on it with a note in the help text that it requires it. But that's just my personal opinion.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#2 lore raw
In reply to Muli Ben-Yehuda

Ar Llu, 2006-09-25 am 13:11 +0300, ysgrifennodd Muli Ben-Yehuda:

Quoted 3 lines

that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

We should not be including non-free firmware in the kernel, we should be continuing to drive it out into things like initramfs.

Quoted 3 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it

Either select or depend

Alan

#3 lore raw
Quoted 2 lines · Alan Cox

We should not be including non-free firmware in the kernel, we should be continuing to drive it out into things like initramfs.

Right, which is why this was done as one of the conditions for accepting the driver

Quoted 5 lines
Quoted 3 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it

Either select or depend

select, I think.

James

#4 lore raw
Quoted 6 lines · James Bottomley
Quoted 2 lines · Alan Cox

We should not be including non-free firmware in the kernel, we should be continuing to drive it out into things like initramfs.

Right, which is why this was done as one of the conditions for accepting the driver

Fair enough.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it

Either select or depend

select, I think.

aic94xx relies on external firmware and thus requires FW_LOADER.

drivers/scsi/aic94xx/Kconfig +1 -0
diff -r 2e01eba444f0 drivers/scsi/aic94xx/Kconfig
@@ -28,6 +28,7 @@ config SCSI_AIC94XX
 	tristate "Adaptec AIC94xx SAS/SATA support"
 	depends on PCI
 	select SCSI_SAS_LIBSAS
+	select FW_LOADER
 	help
 		This driver supports Adaptec's SAS/SATA 3Gb/s 64 bit PCI-X
 		AIC94xx chip based host adapters.
#5 lore raw
In reply to Muli Ben-Yehuda
Quoted 5 lines · Muli Ben-Yehuda

The recently merged aic94xx in mainline requires external firmware support. This, in turn, necessitates an initrd/initramfs environment that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

initramfs is always in use. Wether you pass in an additional image via the bootloader is up to you.
Adding the firmware and required tools to your vmlinux binary is trivial with CONFIG_INITRAMFS_SOURCE="/some/file"

Quoted 5 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it, or FW_LOADER providing empty request_firmware() in case it's compiled out (the last one violates the principle of least surprise IMHO).

select FW_LOADER is likely the right fix.

#6 lore raw
Quoted 8 lines · Olaf Hering
Quoted 5 lines · Muli Ben-Yehuda

The recently merged aic94xx in mainline requires external firmware support. This, in turn, necessitates an initrd/initramfs environment that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

Quoted 4 lines

initramfs is always in use. Wether you pass in an additional image via the bootloader is up to you.
Adding the firmware and required tools to your vmlinux binary is trivial with CONFIG_INITRAMFS_SOURCE="/some/file"

Thanks, I'll look into this.

Cheers,
Muli

#7 lore raw
In reply to Muli Ben-Yehuda
Quoted 8 lines · Muli Ben-Yehuda

Hi,

The recently merged aic94xx in mainline requires external firmware support. This, in turn, necessitates an initrd/initramfs environment that includes firmware support to load the firmware. Will a patch to optionally include the firmware inline in the kernel and thus not having to use an initramfs be acceptable?

Quoted 5 lines

Also, aic94xx does not compile unless FW_LOADER is set in .config due to missing 'request_firmware'. What's the right thing to do here - aic94xx selecting it, depending on it, or FW_LOADER providing empty request_firmware() in case it's compiled out (the last one violates the principle of least surprise IMHO).

While we're at it, already existing aicXXXX driver continues to be insanely large due to excessive inlining of I/O routines:

# x86_64-pc-linux-gnu-size aic7xxx.o
   text    data     bss     dec     hex filename
 118978   22673     568  142219   22b8b aic7xxx.o

This is not even helping performance one iota.
Call overhead for these routines pales in comparison
to I/O instruction stalls, which is in turn pales in comparison to disk seek delays.

Please do something with it.
--
vda