Skip to contentSkip to conversation

eCryptfs: Grab lock on lower_page in ecryptfs_sync_page

PATCH New Michael Halcrow 1 participant 1 message Sep 27, 2006 Ecrypt file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eCryptfs: Grab lock on lower_page in ecryptfs_sync_page

The recent swap of grab_cache_page() with find_get_page() in ecryptfs_sync_page() missed the fact that we need a lock on the lower page. This patch replaces find_get_page() with find_lock_page() in order to make sure that this lock is obtained.

---

 fs/ecryptfs/mmap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

ef0b82f22907486bd87f8c37508a9f7d1dcd5601

fs/ecryptfs/mmap.c +2 -2
index 8a4040d..924dd90 100644
@@ -766,9 +766,9 @@ static void ecryptfs_sync_page(struct pa
 	lower_inode = ecryptfs_inode_to_lower(inode);
 	/* NOTE: Recently swapped with grab_cache_page(), since
 	 * sync_page() just makes sure that pending I/O gets done. */
-	lower_page = find_get_page(lower_inode->i_mapping, page->index);
+	lower_page = find_lock_page(lower_inode->i_mapping, page->index);
 	if (!lower_page) {
-		ecryptfs_printk(KERN_DEBUG, "find_get_page failed\n");
+		ecryptfs_printk(KERN_DEBUG, "find_lock_page failed\n");
 		return;
 	}
 	lower_page->mapping->a_ops->sync_page(lower_page);
Signature · 1 line
1.3.3