add XARGS to toplevel Makefile
PATCH 1/1 add XARGS to toplevel Makefile
run xargs with --no-run-if-empty to avoid random failures:
MAKE tags
ctags: No files specified. Try "ctags --help".
make: *** [tags] Error 123
--- Makefile | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
Makefile +13 -12
@@ -295,6 +295,7 @@ DEPMOD = /sbin/depmod KALLSYMS = scripts/kallsyms PERL = perl CHECK = sparse +XARGS = xargs --no-run-if-empty CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise $(CF) MODFLAGS = -DMODULE
@@ -1049,7 +1050,7 @@ clean: archclean $(clean-dirs) \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ -o -name '*.symtypes' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f # mrproper - Delete all generated files, including .config #
@@ -1075,7 +1076,7 @@ distclean: mrproper -o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \ -o -name '.*.rej' -o -size 0 \ -o -name '*%' -o -name '.*.cmd' -o -name 'core' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f # Packaging of the kernel to various formats
@@ -1237,7 +1238,7 @@ clean: $(clean-dirs) @find $(KBUILD_EXTMOD) $(RCS_FIND_IGNORE) \ \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f help: @echo ' Building external modules.'
@@ -1313,26 +1314,26 @@ endef define xtags if $1 --version 2>&1 | grep -iq exuberant; then \ - $(all-sources) | xargs $1 -a \ + $(all-sources) | $(XARGS) $1 -a \ -I __initdata,__exitdata,__acquires,__releases \ -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ --extra=+f --c-kinds=+px; \ - $(all-kconfigs) | xargs $1 -a \ + $(all-kconfigs) | $(XARGS) $1 -a \ --langdef=kconfig \ --language-force=kconfig \ --regex-kconfig='/^[[:blank:]]*config[[:blank:]]+([[:alnum:]_]+)/\1/'; \ - $(all-defconfigs) | xargs $1 -a \ + $(all-defconfigs) | $(XARGS) $1 -a \ --langdef=dotconfig \ --language-force=dotconfig \ --regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'; \ elif $1 --version 2>&1 | grep -iq emacs; then \ - $(all-sources) | xargs $1 -a; \ - $(all-kconfigs) | xargs $1 -a \ + $(all-sources) | $(XARGS) $1 -a; \ + $(all-kconfigs) | $(XARGS) $1 -a \ --regex='/^[ \t]*config[ \t]+\([a-zA-Z0-9_]+\)/\1/'; \ - $(all-defconfigs) | xargs $1 -a \ + $(all-defconfigs) | $(XARGS) $1 -a \ --regex='/^#?[ \t]?\(CONFIG_[a-zA-Z0-9_]+\)/\1/'; \ else \ - $(all-sources) | xargs $1 -a; \ + $(all-sources) | $(XARGS) $1 -a; \ fi endef
@@ -1371,12 +1372,12 @@ tags: FORCE includecheck: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \ - | xargs $(PERL) -w scripts/checkincludes.pl + | $(XARGS) $(PERL) -w scripts/checkincludes.pl versioncheck: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \ - | xargs $(PERL) -w scripts/checkversion.pl + | $(XARGS) $(PERL) -w scripts/checkversion.pl namespacecheck: $(PERL) $(srctree)/scripts/namespace.pl
Quoted 2 lines
run xargs with --no-run-if-empty to avoid random failures:
How about the short option, -r?
Jan Engelhardt
Quoted 4 lines · Jan Engelhardt
Quoted 2 lines
run xargs with --no-run-if-empty to avoid random failures:
How about the short option, -r?
Is it more portable - otherwise the more descriptive option is preferred.
Sam
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
run xargs with --no-run-if-empty to avoid random failures:
How about the short option, -r?
Is it more portable - otherwise the more descriptive option is preferred.
Neither is portable, and -r tends to hide real bugs; please use something else instead, like making the relevant makefile targets non-fatal (lots of-em already are).
Segher
PATCH 1/1 add XARGS to toplevel Makefile
In reply to Olaf Heringrun xargs with --no-run-if-empty to avoid random failures:
MAKE tags
ctags: No files specified. Try "ctags --help".
make: *** [tags] Error 123
--- Makefile | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)
Makefile +14 -12
@@ -295,6 +295,8 @@ DEPMOD = /sbin/depmod KALLSYMS = scripts/kallsyms PERL = perl CHECK = sparse +# assume xargs comes from GNU findutils or GNU coreutils +XARGS = $(shell if [ "$$(uname -s)" = "Linux" ]; then echo "xargs --no-run-if-empty" ; else echo "xargs" ; fi ) CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise $(CF) MODFLAGS = -DMODULE
@@ -1049,7 +1051,7 @@ clean: archclean $(clean-dirs) \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ -o -name '*.symtypes' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f # mrproper - Delete all generated files, including .config #
@@ -1075,7 +1077,7 @@ distclean: mrproper -o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \ -o -name '.*.rej' -o -size 0 \ -o -name '*%' -o -name '.*.cmd' -o -name 'core' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f # Packaging of the kernel to various formats
@@ -1237,7 +1239,7 @@ clean: $(clean-dirs) @find $(KBUILD_EXTMOD) $(RCS_FIND_IGNORE) \ \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \) \ - -type f -print | xargs rm -f + -type f -print | $(XARGS) rm -f help: @echo ' Building external modules.'
@@ -1313,26 +1315,26 @@ endef define xtags if $1 --version 2>&1 | grep -iq exuberant; then \ - $(all-sources) | xargs $1 -a \ + $(all-sources) | $(XARGS) $1 -a \ -I __initdata,__exitdata,__acquires,__releases \ -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ --extra=+f --c-kinds=+px; \ - $(all-kconfigs) | xargs $1 -a \ + $(all-kconfigs) | $(XARGS) $1 -a \ --langdef=kconfig \ --language-force=kconfig \ --regex-kconfig='/^[[:blank:]]*config[[:blank:]]+([[:alnum:]_]+)/\1/'; \ - $(all-defconfigs) | xargs $1 -a \ + $(all-defconfigs) | $(XARGS) $1 -a \ --langdef=dotconfig \ --language-force=dotconfig \ --regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'; \ elif $1 --version 2>&1 | grep -iq emacs; then \ - $(all-sources) | xargs $1 -a; \ - $(all-kconfigs) | xargs $1 -a \ + $(all-sources) | $(XARGS) $1 -a; \ + $(all-kconfigs) | $(XARGS) $1 -a \ --regex='/^[ \t]*config[ \t]+\([a-zA-Z0-9_]+\)/\1/'; \ - $(all-defconfigs) | xargs $1 -a \ + $(all-defconfigs) | $(XARGS) $1 -a \ --regex='/^#?[ \t]?\(CONFIG_[a-zA-Z0-9_]+\)/\1/'; \ else \ - $(all-sources) | xargs $1 -a; \ + $(all-sources) | $(XARGS) $1 -a; \ fi endef
@@ -1371,12 +1373,12 @@ tags: FORCE includecheck: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \ - | xargs $(PERL) -w scripts/checkincludes.pl + | $(XARGS) $(PERL) -w scripts/checkincludes.pl versioncheck: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \ - | xargs $(PERL) -w scripts/checkversion.pl + | $(XARGS) $(PERL) -w scripts/checkversion.pl namespacecheck: $(PERL) $(srctree)/scripts/namespace.pl
Hi Olaf,
Makefile DEPMOD = /sbin/depmod · line 299
Quoted 9 lines · Olaf Hering
run xargs with --no-run-if-empty to avoid random failures:
MAKE tags
ctags: No files specified. Try "ctags --help".
make: *** [tags] Error 123Makefile +2
-0+# assume xargs comes from GNU findutils or GNU coreutils +XARGS = $(shell if [ "$$(uname -s)" = "Linux" ]; then echo "xargs --no-run-if-empty" ; else echo "xargs" ; fi )
I'd rather test xargs' support for the option than check the OS with uname. Something like the following might a little bit be more appropriate :
XARGS = $(shell if xargs --no-run-if-empty true </dev/null 2>/dev/null; then echo "xargs --no-run-if-empty" ; else echo "xargs" ; fi )
Best regards,
Willy