Skip to contentSkip to conversation

Avoid static struct initializations in appldata.

S390 Martin Schwidefsky 1 participant 1 message Sep 28, 2006 s390

lore
Share & tools
lore
#0 lore raw

From: Gerald Schaefer <[email protected]>

[S390] Avoid static struct initializations in appldata.

Don't use static initialization for struct members containing variables because gcc would generate more code and use double space on stack.

---

 arch/s390/appldata/appldata_base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/s390/appldata/appldata_base.c +2 -2
diff -urpN linux-2.6/arch/s390/appldata/appldata_base.c linux-2.6-patched/arch/s390/appldata/appldata_base.c
@@ -157,12 +157,12 @@ int appldata_diag(char record_nr, u16 fu
 		.prod_nr    = {0xD3, 0xC9, 0xD5, 0xE4,
 			       0xE7, 0xD2, 0xD9},	/* "LINUXKR" */
 		.prod_fn    = 0xD5D3,			/* "NL" */
-		.record_nr  = record_nr,
 		.version_nr = 0xF2F6,			/* "26" */
 		.release_nr = 0xF0F1,			/* "01" */
-		.mod_lvl    = (mod_lvl[0]) << 8 | mod_lvl[1],
 	};
 
+	id.record_nr = record_nr;
+	id.mod_lvl = (mod_lvl[0]) << 8 | mod_lvl[1];
 	return appldata_asm(&id, function, (void *) buffer, length);
 }
 /************************ timer, work, DIAG <END> ****************************/