scsi: device_reprobe() can fail

PATCH New Jeff Garzik 1 participant 1 message Oct 1, 2006 SCSI

Share & tools

Jeff Garzik

author

2006-10-01 01:23 UTC #0 lore raw

PATCH 1/1 scsi: device_reprobe() can fail

[This has been sitting in James Bottomley's scsi-misc for five days.
With SCSI outputting a warning for almost -every- file, let's go ahead and get the patch in.]

From: Andrew Morton <[email protected]>

device_reprobe() should return an error code. When it does so, scsi_device_reprobe() should propagate it back.

Acked-by Jeff Garzik <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

Signed-off-by James Bottomley <[email protected]>

---

 include/scsi/scsi_device.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

8350a348e97c2f8aa3e91c025c0e040c90146414

include/scsi/scsi_device.h +2 -2

index 895d212..b401c82 100644
@@ -298,9 +298,9 @@ extern int scsi_execute_async(struct scs
 			      void (*done)(void *, char *, int, int),
 			      gfp_t gfp);
 
-static inline void scsi_device_reprobe(struct scsi_device *sdev)
+static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev)
 {
-	device_reprobe(&sdev->sdev_gendev);
+	return device_reprobe(&sdev->sdev_gendev);
 }
 
 static inline unsigned int sdev_channel(struct scsi_device *sdev)