Skip to contentSkip to conversation

string initialization in ForeRunnerHE driver

PATCH New Andi Drebes 1 participant 1 message Oct 1, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 string initialization in ForeRunnerHE driver

I had a look at http://www.kerneljanitors.org/TODO
Jeff Garzik writes that in most cases a string initialization like char foo[] = "blah"; is preferred to an initialization like char *foo = "blah"; So I grep'd around the kernel sources and found an initialization in the latter style in drivers/atm/he.c. This is my first patch ever sent to the kj-mailing-list. I hope everything is fine with the patch-format and so on. If not, please let me know...
I don't know if this patch is really needed. However, here it is (tested by compilation):

drivers/atm/he.c +1 -1
index f2511b4..f16a1ce 100644
@@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
 
 /* version definition */
 
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
+static char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
 
 /* declarations */
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors