Skip to contentSkip to conversation

ipmi: fix uninit'd data bug

PATCH New Jeff Garzik 1 participant 1 message Oct 1, 2006 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmi: fix uninit'd data bug

gcc issues the following warning:

drivers/char/ipmi/ipmi_si_intf.c: In function ‘init_ipmi_si’:
drivers/char/ipmi/ipmi_si_intf.c:1729: warning: ‘data.irq’ may be used uninitialized in this function

This is indeed a bug. data.irq is completely uninitialized in some code paths. Worse than that, data from a previous decode_dmi() run can easily leak through successive calls.

drivers/char/ipmi/ipmi_si_intf.c +1 -0
index abca98b..0afd7f8 100644
@@ -1730,6 +1730,7 @@ static void __devinit dmi_find_bmc(void)
 	int                  rv;
 
 	while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) {
+		memset(&data, 0, sizeof(data));
 		rv = decode_dmi((struct dmi_header *) dev->device_data, &data);
 		if (!rv)
 			try_init_dmi(&data);