Skip to contentSkip to conversation

drivers/atm: No need to return void

PATCH In review Tobias Klauser 2 participants 2 messages Oct 4, 2006 – Oct 16, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/atm: No need to return void

The module_exit function has return-type void and
pci_unregister_driver() returns void anyway.

---
 drivers/atm/ambassador.c |    4 ++--
 drivers/atm/horizon.c    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/atm/ambassador.c +2 -2
index 4521a24..9ccb9e3 100644
@@ -2459,8 +2459,8 @@ static int __init amb_module_init (void)
 static void __exit amb_module_exit (void)
 {
   PRINTD (DBG_FLOW|DBG_INIT, "cleanup_module");
-  
-  return pci_unregister_driver(&amb_driver);
+
+  pci_unregister_driver(&amb_driver);
 }
 
 module_init(amb_module_init);
drivers/atm/horizon.c +2 -2
index d1113e8..6a3bda9 100644
@@ -2945,8 +2945,8 @@ static int __init hrz_module_init (void)
 
 static void __exit hrz_module_exit (void) {
   PRINTD (DBG_FLOW, "cleanup_module");
-  
-  return pci_unregister_driver(&hrz_driver);
+
+  pci_unregister_driver(&hrz_driver);
 }
 
 module_init(hrz_module_init);
Signature · 6 lines
1.4.2

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#1 lore raw

drivers/atm/ambassador.c static int __init amb_module_init (void) · line 2463

Quoted 5 lines · Tobias Klauser

The module_exit function has return-type void and
pci_unregister_driver() returns void anyway.

drivers/atm/ambassador.c +1 -1
-  return pci_unregister_driver(&amb_driver);
+  pci_unregister_driver(&amb_driver);

Logical continuation would be a patch so sparse(1) would start warning about such things.

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors