Skip to contentSkip to conversation

it87: Remove the SMBus interface support

PATCH New Jean Delvare 1 participant 1 message Oct 7, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 it87: Remove the SMBus interface support

Remove the SMBus interface support from the it87 hardware monitoring driver. This interface was useless as the LPC ISA-like interface is always available, is faster, and is more reliable. This cuts the driver size by some 20%.

This change is also required to later convert the it87 driver to a platform driver, so that we can get rid of i2c-isa in a near future.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
 Documentation/feature-removal-schedule.txt |    9 -
 Documentation/hwmon/it87                   |   15 ++
 drivers/hwmon/it87.c                       |  202 +++++++---------------------
 include/linux/i2c-id.h                     |    1 -
 4 files changed, 64 insertions(+), 163 deletions(-)
Documentation/hwmon/it87 +13 -2
@@ -9,8 +9,7 @@
                http://www.ite.com.tw/
   * IT8712F
     Prefix: 'it8712'
-    Addresses scanned: I2C 0x2d
-                       from Super I/O config space (8 I/O ports)
+    Addresses scanned: from Super I/O config space (8 I/O ports)
     Datasheet: Publicly available at the ITE website
                http://www.ite.com.tw/
   * IT8716F
@@ -53,6 +52,18 @@
   misconfigured by BIOS - PWM values would be inverted. This option tries
   to fix this. Please contact your BIOS manufacturer and ask him for fix.
 
+
+Hardware Interfaces
+-------------------
+
+All the chips suported by this driver are LPC Super-I/O chips, accessed
+through the LPC bus (ISA-like I/O ports). The IT8712F additionally has an
+SMBus interface to the hardware monitoring functions. This driver no
+longer supports this interface though, as it is slower and less reliable
+than the ISA access, and was only available on a small number of
+motherboard models.
+
+
 Description
 -----------
 
drivers/hwmon/it87.c +51 -151

326 lines not on this page · raw message

Documentation/feature-removal-schedule.txt +0 -9
@@ -147,15 +147,6 @@
 
 ---------------------------
 
-What:	I2C interface of the it87 driver
-When:	January 2007
-Why:	The ISA interface is faster and should be always available. The I2C
-	probing is also known to cause trouble in at least one case (see
-	bug #5889.)
-Who:	Jean Delvare <khali at linux-fr.org>
-
----------------------------
-
 What:	Unused EXPORT_SYMBOL/EXPORT_SYMBOL_GPL exports
 	(temporary transition config option provided until then)
 	The transition config option will also be removed at the same time.
include/linux/i2c-id.h +0 -1
@@ -143,7 +143,6 @@
 #define I2C_DRIVERID_MTP008 1023
 #define I2C_DRIVERID_DS1621 1024
 #define I2C_DRIVERID_ADM1024 1025
-#define I2C_DRIVERID_IT87 1026
 #define I2C_DRIVERID_CH700X 1027 /* single driver for CH7003-7009 digital pc to tv encoders */
 #define I2C_DRIVERID_FSCPOS 1028
 #define I2C_DRIVERID_FSCSCY 1029
Signature · 1 line
Jean Delvare