Skip to contentSkip to conversation

HT_IRQ must depend on PCI

PATCH In review Adrian Bunk 2 participants 2 messages Oct 8, 2006 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HT_IRQ must depend on PCI

CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:

<-- snip -->

...
LD vmlinux
arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
summit.c:(.text+0x53): undefined reference to apicid_2_node' arch/i386/kernel/built-in.o: In function arch_setup_ht_irq':
(.text+0xcf79): undefined reference to write_ht_irq_low' arch/i386/kernel/built-in.o: In function arch_setup_ht_irq':
(.text+0xcf85): undefined reference to write_ht_irq_high' arch/i386/kernel/built-in.o: In function k7nops':
alternative.c:(.data+0x1358): undefined reference to mask_ht_irq' alternative.c:(.data+0x1360): undefined reference to unmask_ht_irq' make[1]: *** [vmlinux] Error 1

<-- snip -->

Bug report by Jesper Juhl.

drivers/pci/Kconfig renamed from drivers/pci/Kconfig.old +1 -1
@@ -55,7 +55,7 @@
 config HT_IRQ
 	bool "Interrupts on hypertransport devices"
 	default y
-	depends on X86_LOCAL_APIC && X86_IO_APIC
+	depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
 	help
 	   This allows native hypertransport devices to use interrupts.
 
#1 lore raw

Adrian Bunk <[email protected]> writes:

Looks good to me.

Quoted 34 lines

CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:

<-- snip -->

...
LD vmlinux
arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
summit.c:(.text+0x53): undefined reference to apicid_2_node' arch/i386/kernel/built-in.o: In function arch_setup_ht_irq':
(.text+0xcf79): undefined reference to write_ht_irq_low' arch/i386/kernel/built-in.o: In function arch_setup_ht_irq':
(.text+0xcf85): undefined reference to write_ht_irq_high' arch/i386/kernel/built-in.o: In function k7nops':
alternative.c:(.data+0x1358): undefined reference to mask_ht_irq' alternative.c:(.data+0x1360): undefined reference to unmask_ht_irq' make[1]: *** [vmlinux] Error 1

<-- snip -->

Bug report by Jesper Juhl.

drivers/pci/Kconfig renamed from drivers/pci/Kconfig.old +1 -1
@@ -55,7 +55,7 @@
 config HT_IRQ
 	bool "Interrupts on hypertransport devices"
 	default y
-	depends on X86_LOCAL_APIC && X86_IO_APIC
+	depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
 	help
 	   This allows native hypertransport devices to use interrupts.