drivers/scsi/dpt_i2o.c: remove dead code

The Coverity checker spotted this dead code introduced by commit a07f353701acae77e023f6270e8af353b37af7c4.

@@ -185,28 +185,26 @@
 
         /* search for all Adatpec I2O RAID cards */
 	while ((pDev = pci_get_device( PCI_DPT_VENDOR_ID, PCI_ANY_ID, pDev))) {
 		if(pDev->device == PCI_DPT_DEVICE_ID ||
 		   pDev->device == PCI_DPT_RAPTOR_DEVICE_ID){
 			if(adpt_install_hba(sht, pDev) ){
 				PERROR("Could not Init an I2O RAID device\n");
 				PERROR("Will not try to detect others.\n");
 				return hba_count-1;
 			}
 			pci_dev_get(pDev);
 		}
 	}
-	if (pDev)
-		pci_dev_put(pDev);
 
 	/* In INIT state, Activate IOPs */
 	for (pHba = hba_chain; pHba; pHba = pHba->next) {
 		// Activate does get status , init outbound, and get hrt
 		if (adpt_i2o_activate_hba(pHba) < 0) {
 			adpt_i2o_delete_hba(pHba);
 		}
 	}
 
 
 	/* Active IOPs in HOLD state */
 
 rebuild_sys_tab:

Ar Llu, 2006-10-09 am 01:16 +0200, ysgrifennodd Adrian Bunk:

Semi-NAK

Its not dead jim, its in the wrong location

The current code is:

        /* search for all Adatpec I2O RAID cards */
        while ((pDev = pci_get_device( PCI_DPT_VENDOR_ID, PCI_ANY_ID, pDev))) {
                if(pDev->device == PCI_DPT_DEVICE_ID ||
                   pDev->device == PCI_DPT_RAPTOR_DEVICE_ID){
                        if(adpt_install_hba(sht, pDev) ){
                                PERROR("Could not Init an I2O RAID device\n");
                                PERROR("Will not try to detect others.\n");
                                return hba_count-1;
                        }
                        pci_dev_get(pDev);
                }
        }
        if (pDev)
                pci_dev_put(pDev);

I don't see the point of the suggested place for the pci_dev_put() since pci_dev_get() has never been executed in this case, or do I miss anything?

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Correct, thats what I get for being away and reading 4000 emails when I get back

Alan