Skip to contentSkip to conversation

drivers/usb/serial/mos7840.c: remove dead code

RFC PATCH New Adrian Bunk 1 participant 1 message Oct 8, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 drivers/usb/serial/mos7840.c: remove dead code

The Coverity checker spotted this dead code.

---

 drivers/usb/serial/mos7840.c |   11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/usb/serial/mos7840.c renamed from drivers/usb/serial/mos7840.c.old +1 -10
@@ -1420,7 +1420,6 @@
 	int i;
 	int bytes_sent = 0;
 	int transfer_size;
-	int from_user = 0;
 
 	struct moschip_port *mos7840_port;
 	struct usb_serial *serial;
@@ -1511,15 +1510,7 @@
 	}
 	transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE);
 
-	if (from_user) {
-		if (copy_from_user
-		    (urb->transfer_buffer, current_position, transfer_size)) {
-			bytes_sent = -EFAULT;
-			goto exit;
-		}
-	} else {
-		memcpy(urb->transfer_buffer, current_position, transfer_size);
-	}
+	memcpy(urb->transfer_buffer, current_position, transfer_size);
 
 	/* fill urb with data and submit  */
 	usb_fill_bulk_urb(urb,