Skip to contentSkip to conversation

Kconfig include order of drivers/misc

PATCH Brent Casavant 1 participant 1 message Oct 9, 2006

lore
Share & tools
lore
#0 lore raw

Hello,

I am contemplating a patch which would move the drivers/sn/ioc4.c code into drivers/misc, as the SGI IOC4 device may soon not be limited to operation on the SGI SN2 platform. However, to maintain proper Kconfig dependency ordering, this will require me to move drivers/misc before drivers/ide in the drivers/Kconfig file.

My examination of this change seems to indicate this should not cause any problems for the drivers hosted under drivers/misc, however I wanted to run it by those who have recently (i.e. since "git" began hosting the Linux source) touched the drivers/misc/Kconfig file.

Do any of you anticipate a problem with the following change?

Thanks,
Brent

drivers/Kconfig +4 -2
index 263e86d..f394634 100644
@@ -14,6 +14,10 @@ source "drivers/pnp/Kconfig"
 
 source "drivers/block/Kconfig"
 
+# misc before ide - BLK_DEV_SGIIOC4 depends on SGI_IOC4
+
+source "drivers/misc/Kconfig"
+
 source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
@@ -52,8 +56,6 @@ source "drivers/w1/Kconfig"
 
 source "drivers/hwmon/Kconfig"
 
-source "drivers/misc/Kconfig"
-
 source "drivers/mfd/Kconfig"
 
 source "drivers/media/Kconfig"
Signature · 3 lines
Brent Casavant                          All music is folk music.  I ain't
[email protected]                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong