Skip to contentSkip to conversation

zfcp: initialize scsi_host_template.max_sectors with appropriate value

PATCH In review Swen Schillig 2 participants 3 messages Oct 9, 2006 – Oct 12, 2006

Subsystems (3)
SCSI s390 s390 zfcp driver
lore
Share & tools
lore

Swen Schillig

author
#0 lore raw

PATCH 1/1 zfcp: initialize scsi_host_template.max_sectors with appropriate value

commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941

Author: Swen Schillig <[email protected]>
Date:   Mon Oct 9 14:59:08 2006 +0200

Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with appropriate value.

ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
/* max. number of (data buffer) SBALEs in largest SBAL chain
multiplied with number of sectors per 4k block */

##############################################

drivers/s390/scsi/zfcp_def.h +4 -0
index 8f88269..88591a4 100644
@@ -107,6 +107,10 @@ #define ZFCP_MAX_SBALES_PER_REQ            \
        (ZFCP_MAX_SBALS_PER_REQ * ZFCP_MAX_SBALES_PER_SBAL - 2)
         /* request ID + QTCB in SBALE 0 + 1 of first SBAL in chain */
 
+#define ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
+       /* max. number of (data buffer) SBALEs in largest SBAL chain
+          multiplied with number of sectors per 4k block */
+
 /* FIXME(tune): free space should be one max. SBAL chain plus what? */
 #define ZFCP_QDIO_PCI_INTERVAL         (QDIO_MAX_BUFFERS_PER_Q \
                                          - (ZFCP_MAX_SBALS_PER_REQ + 4))
drivers/s390/scsi/zfcp_scsi.c +1 -0
index 7cafa34..71fee53 100644
@@ -58,6 +58,7 @@ struct zfcp_data zfcp_data = {
                .cmd_per_lun            = 1,
                .use_clustering         = 1,
                .sdev_attrs             = zfcp_sysfs_sdev_attrs,
+               .max_sectors            = ZFCP_MAX_SECTORS,
        },
        .driver_version = ZFCP_VERSION,
 };
#1 lore raw
Quoted 10 lines · Swen Schillig

commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941

Author: Swen Schillig <[email protected]>
Date:   Mon Oct 9 14:59:08 2006 +0200

Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with appropriate value.

ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
/* max. number of (data buffer) SBALEs in largest SBAL chain
multiplied with number of sectors per 4k block */

This needs a signoff.

Plus it doesn't apply: it looks like your mailer has converted tabs to spaces.

James

author
#2 lore raw

Sorry James

won't happen again.

###############################################

commit 9ceca33ffd6287163e39030f3a5c6fad60d17f7b

Author: Swen Schillig <[email protected]>
Date:   Thu Oct 12 11:24:54 2006 +0200

Define ZFCP_MAX_SECTORS and initialize scsi_host_template.max_sectors with appropriate value.

Signed-off-by Swen Schillig <[email protected]>
drivers/s390/scsi/zfcp_def.h +4 -0
index 8f88269..74c0eac 100644
@@ -107,6 +107,10 @@ #define ZFCP_MAX_SBALES_PER_REQ		\
 	(ZFCP_MAX_SBALS_PER_REQ * ZFCP_MAX_SBALES_PER_SBAL - 2)
         /* request ID + QTCB in SBALE 0 + 1 of first SBAL in chain */
 
+#define ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
+        /* max. number of (data buffer) SBALEs in largest SBAL chain
+           multiplied with number of sectors per 4k block */
+
 /* FIXME(tune): free space should be one max. SBAL chain plus what? */
 #define ZFCP_QDIO_PCI_INTERVAL		(QDIO_MAX_BUFFERS_PER_Q \
                                          - (ZFCP_MAX_SBALS_PER_REQ + 4))
drivers/s390/scsi/zfcp_scsi.c +1 -0
index 4d2bc79..452d96f 100644
@@ -58,6 +58,7 @@ struct zfcp_data zfcp_data = {
 		.cmd_per_lun		= 1,
 		.use_clustering		= 1,
 		.sdev_attrs		= zfcp_sysfs_sdev_attrs,
+		.max_sectors		= ZFCP_MAX_SECTORS,
 	},
 	.driver_version = ZFCP_VERSION,
 };
Quoted 25 lines · you
Quoted 10 lines · Swen Schillig

commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941

Author: Swen Schillig <[email protected]>
Date:   Mon Oct 9 14:59:08 2006 +0200

Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with appropriate value.

ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
/* max. number of (data buffer) SBALEs in largest SBAL chain
multiplied with number of sectors per 4k block */

This needs a signoff.

Plus it doesn't apply: it looks like your mailer has converted tabs to spaces.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html