Skip to contentSkip to conversation

fdtable: Avoid fdset cacheline ping-pong.

PATCH New Vadim Lobanov 1 participant 1 message Oct 14, 2006 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 fdtable: Avoid fdset cacheline ping-pong.

This is a performance optimization for the fdtable code. When expanding the fdtable for a task, we want to allocate at least L1_CACHE_BYTES for the new fdset memory -- this will ensure that the fdsets of two different tasks will not share the same cacheline, causing lots of cacheline ping-pongs.

fs/file.c +2 -1
diff -Npru old/fs/file.c new/fs/file.c
@@ -178,7 +178,8 @@ static struct fdtable * alloc_fdtable(un
 	if (!data)
 		goto out_fdt;
 	fdt->fd = (struct file **)data;
-	data = alloc_fdmem(2 * nr / BITS_PER_BYTE);
+	data = alloc_fdmem(max_t(unsigned int,
+				 2 * nr / BITS_PER_BYTE, L1_CACHE_BYTES));
 	if (!data)
 		goto out_arr;
 	fdt->open_fds = (fd_set *)data;