Fix return codes in failure case.
These returns should be negative, like the others in this function.
Signed-off-by Dave Jones <[email protected]>
drivers/char/ipmi/ipmi_si_intf.c +2 -2
@@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru info =kzalloc (sizeof (*info),GFP_KERNEL );if (!info) -return ENOMEM ; +return -ENOMEM ; info->addr_source ="PCI" ;
@@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(strukfree (info);printk (KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n" ,pci_name (pdev), class_type); -return ENOMEM ; +return -ENOMEM ; } rv =pci_enable_device (pdev);
Signature · 1 line
http://www.codemonkey.org.uk
Thanks, looks good.
-Corey
Quoted 28 lines · Dave Jones
These returns should be negative, like the others in this function.
Signed-off-by Dave Jones <[email protected]>drivers/char/ipmi/ipmi_si_intf.c +2
-2@@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru info =kzalloc (sizeof (*info),GFP_KERNEL );if (!info) -return ENOMEM ; +return -ENOMEM ; info->addr_source ="PCI" ;@@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(strukfree (info);printk (KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n" ,pci_name (pdev), class_type); -return ENOMEM ; +return -ENOMEM ; } rv =pci_enable_device (pdev);