Skip to contentSkip to conversation

revert mv643xx change from ubuntu tree

DISCUSSION Olaf Hering 2 participants 3 messages Oct 19, 2006 – Oct 20, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Somehow the Ubuntu guys managed to sneak this compile error into the tree:

commit ce9e3d9953c8cb67001719b5516da2928e956be4

[mv643xx] Add pci device table for auto module loading.

drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’ drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function) drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)

This change is also wrong, the autoloading works perfect with 2.6.18, no need to add random PCI ids.

http://ozlabs.org/pipermail/linuxppc-dev/2006-October/026544.html

Please revert this change and route changes via jgarzik etc...

#1 lore raw
Quoted 11 lines · Olaf Hering

Somehow the Ubuntu guys managed to sneak this compile error into the tree:

commit ce9e3d9953c8cb67001719b5516da2928e956be4

[mv643xx] Add pci device table for auto module loading.

drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’ drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function) drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)

Correct, I missed the include for linux/pci.h.

This patch has been trailing our tree since 2.6.12. Could you help me to understand what in this driver will cause it to be autoloaded by udev when compiled as a module?

#2 lore raw
Quoted 13 lines · Ben Collins
Quoted 11 lines · Olaf Hering

Somehow the Ubuntu guys managed to sneak this compile error into the tree:

commit ce9e3d9953c8cb67001719b5516da2928e956be4

[mv643xx] Add pci device table for auto module loading.

drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’ drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function) drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)

Quoted 5 lines

Correct, I missed the include for linux/pci.h.

This patch has been trailing our tree since 2.6.12. Could you help me to understand what in this driver will cause it to be autoloaded by udev when compiled as a module?

See commit ce9e3d9953c8cb67001719b5516da2928e956be4, platform devices have now a modalias entry in sysfs. The network card is not a PCI device.