Skip to contentSkip to conversation

cpuset: mempolicy migration typo fix

PATCH New Paul Jackson 1 participant 1 message Oct 20, 2006 MM NUMA placement

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuset: mempolicy migration typo fix

From: Paul Jackson <[email protected]>

Mistyped an ifdef CONFIG_CPUSETS - fixed.

I doubt that anyone ever noticed. The impact of this typo was that if someone:
1) was using MPOL_BIND to force off node allocations
2) while using cpusets to constrain memory placement
3) when that cpuset was migrating that jobs memory
4) while the tasks in that job were actively forking
then there was a rare chance that future allocations using that MPOL_BIND policy would be node local, not off node.

---

It builds under my cross tool setup, it runs my usual cpuset tests and it runs my not particularly elaborate cpuset memory migration test.

 include/linux/mempolicy.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mempolicy.h +1 -1
@@ -150,7 +150,7 @@ extern void mpol_rebind_mm(struct mm_str
 extern void mpol_fix_fork_child_flag(struct task_struct *p);
 #define set_cpuset_being_rebound(x) (cpuset_being_rebound = (x))
 
-#ifdef CONFIG_CPUSET
+#ifdef CONFIG_CPUSETS
 #define current_cpuset_is_being_rebound() \
 				(cpuset_being_rebound == current->cpuset)
 #else
Signature · 3 lines
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <[email protected]> 1.925.600.0401