Skip to contentSkip to conversation

Dont map PAL memory if physicall calls are going to be made

PATCH In review Horms 2 participants 4 messages Oct 23, 2006 – Dec 13, 2006

lore
Share & tools
lore

Horms

author
#0 lore raw

PATCH 3/5 Dont map PAL memory if physicall calls are going to be made

There seems to be no reason to map the PAL code into memory if physical calls are going to be made.

 arch/ia64/kernel/efi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: kexec-ia64-2.6/arch/ia64/kernel/efi.c
=================================--- kexec-ia64-2.6.orig/arch/ia64/kernel/efi.c 2006-10-05 12:51:49.000000000 +0900
+++ kexec-ia64-2.6/arch/ia64/kernel/efi.c 2006-10-05 12:52:10.000000000 +0900
@@ -527,7 +528,6 @@
}
#endif

- efi_map_pal_code();
efi_enter_virtual_mode();
}

@@ -601,6 +601,8 @@
efi.set_variable = virt_set_variable; efi.get_next_high_mono_count = virt_get_next_high_mono_count; efi.reset_system = virt_reset_system;
+
+ efi_map_pal_code();
}

/*

--

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/
#1 lore raw
Quoted 2 lines · Horms

There seems to be no reason to map the PAL code into memory if physical calls are going to be made.

If you don't map PAL, I assume that all PAL calls are going to be made in physical addressing mode. However, I don't see any code that actually forces PAL calls to be made in physical addressing mode. Is that your intent? Don't you also need to save the PAL start address as a physical address. See the call to ia64_pal_handler_init().

In addition, it looks like slave cpus still call efi_map_pal_code() to map PAL - see start_secondary().

Quoted 38 lines
 arch/ia64/kernel/efi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: kexec-ia64-2.6/arch/ia64/kernel/efi.c
=================================> --- kexec-ia64-2.6.orig/arch/ia64/kernel/efi.c 2006-10-05 12:51:49.000000000 +0900
+++ kexec-ia64-2.6/arch/ia64/kernel/efi.c 2006-10-05 12:52:10.000000000 +0900

(quoted diff) +2 -2
@@ -527,7 +528,6 @@
 	}
 #endif
 
-	efi_map_pal_code();
 	efi_enter_virtual_mode();
 }
 
@@ -601,6 +601,8 @@
 	efi.set_variable = virt_set_variable;
 	efi.get_next_high_mono_count = virt_get_next_high_mono_count;
 	efi.reset_system = virt_reset_system;
+
+	efi_map_pal_code();
 }
 
 /*
 
--
Signature · 9 lines
-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 4 lines
Thanks

Jack Steiner ([email protected])          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.
author
#2 lore raw
In reply to Horms
Quoted 8 lines · Jack Steiner
Quoted 2 lines · Horms

There seems to be no reason to map the PAL code into memory if physical calls are going to be made.

If you don't map PAL, I assume that all PAL calls are going to be made in physical addressing mode. However, I don't see any code that actually forces PAL calls to be made in physical addressing mode.

I was thinking that making the SAL calls physical would do this, but perhaps it is not sufficient.

http://marc.theaimsgroup.com/?l=linux-ia64&m6159434527220&w=2
http://marc.theaimsgroup.com/?l=linux-ia64&m6159434413928&w=2

Quoted 6 lines

Is that your intent?
Don't you also need to save the PAL start address as a physical address. See the call to ia64_pal_handler_init().

In addition, it looks like slave cpus still call efi_map_pal_code() to map PAL - see start_secondary().

Thanks, I will look into that code and get back to you.

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/
author
#3 lore raw
In reply to Horms
Quoted 10 lines · Jack Steiner
Quoted 2 lines · Horms

There seems to be no reason to map the PAL code into memory if physical calls are going to be made.

If you don't map PAL, I assume that all PAL calls are going to be made in physical addressing mode. However, I don't see any code that actually forces PAL calls to be made in physical addressing mode. Is that your intent? Don't you also need to save the PAL start address as a physical address. See the call to ia64_pal_handler_init().

Thanks. On furtuther investigation I think that this patch is bogus. I will remove it from the series.

Quoted 2 lines

In addition, it looks like slave cpus still call efi_map_pal_code() to map PAL - see start_secondary().

Just for the record, that itself is easy enough to get around by checking for efi.mapped in efi_map_pal_code() or start_secondary().

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/