Skip to contentSkip to conversation

Reporting wrong status for non-existant files

PATCH RESEND In review Glauber de Oliveira Costa 2 participants 2 messages Oct 25, 2006 – Nov 1, 2006

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Reporting wrong status for non-existant files

Hi,

The block scripts under tools/examples is not reporting the proper information in the event of a non-exitent file being passed on, like in "file:/nonexistant,hda,w".

Signature · 3 lines
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

# HG changeset patch
# User [email protected]
# Date 1161631865 14400
# Node ID 6b28d144c5814b5206592e93bcea4b7d0a752e8a
# Parent 29b02d929b7e4df6016c16ebba71d6d73462882e
The block script is reporting the file as non-writable, even if it does not exists

tools/examples/block +9 -1
diff -r 29b02d929b7e -r 6b28d144c581 tools/examples/block
@@ -266,7 +266,15 @@ case "$command" in
 
         claim_lock "block"
 
-        if [ "$mode" == 'w' ] && ! stat "$file" -c %A | grep -q w
+        fstat=$(stat "$file" -c %A)
+        if [ "$?" == '1' ];
+        then
+          release_lock "block"
+          ebusy \
+"File $file not found."
+        fi
+
+        if [ "$mode" == 'w' ] && ! echo $fstat | grep -q w
         then
           release_lock "block"
           ebusy \

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

any comments here?

Quoted 51 lines · Glauber de Oliveira Costa

Hi,

The block scripts under tools/examples is not reporting the proper information in the event of a non-exitent file being passed on, like in "file:/nonexistant,hda,w".

--
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

# HG changeset patch
# User [email protected]
# Date 1161631865 14400
# Node ID 6b28d144c5814b5206592e93bcea4b7d0a752e8a
# Parent 29b02d929b7e4df6016c16ebba71d6d73462882e
The block script is reporting the file as non-writable, even if it does not exists

diff -r 29b02d929b7e -r 6b28d144c581 tools/examples/block

tools/examples/block Mon Oct 23 15:31:05 2006 -0400 renamed from tools/examples/block Mon Oct 23 14:42:52 2006 +0100 +9 -1
@@ -266,7 +266,15 @@ case "$command" in
 
         claim_lock "block"
 
-        if [ "$mode" == 'w' ] && ! stat "$file" -c %A | grep -q w
+        fstat=$(stat "$file" -c %A)
+        if [ "$?" == '1' ];
+        then
+          release_lock "block"
+          ebusy \
+"File $file not found."
+        fi
+
+        if [ "$mode" == 'w' ] && ! echo $fstat | grep -q w
         then
           release_lock "block"
           ebusy \

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 5 lines
Glauber de Oliveira Costa.
"Free as in Freedom"

Add your comments to GPLv3 at:
http://gplv3.fsf.org/comments/gplv3-draft-2.html