Skip to contentSkip to conversation

Better error reporting in config file parsing errors

PATCH RESEND In review Glauber de Oliveira Costa 2 participants 2 messages Oct 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Better error reporting in config file parsing errors

Hello,

I lost some time today using xm create, while invoking 'xm create cfg', because I accidentally had a file called 'cfg' in my current working directory. As the error dumping refers only to 'cfg', it revealed itself somehow tricky to figure out.

I'm attaching a patch that informs the complete path of the file being processing, besides giving a more complete error message that would give more valuable input to help finding any issues.

Signature · 3 lines
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"
tools/python/xen/xm/opts.py renamed from tools/python/xen/xm/opts.py.orig +6 -5
@@ -483,11 +483,8 @@ class Opts:
         'path'    search path
         'defconfig' script name
         """
-        for x in [ '' ] + self.vals.path.split(':'):
-            if x:
-                p = os.path.join(x, self.vals.defconfig)
-            else:
-                p = self.vals.defconfig
+        for x in [ os.path.curdir ] + self.vals.path.split(':'):
+            p = os.path.join(x, self.vals.defconfig)
             if os.path.exists(p):
                 self.info('Using config file "%s".' % p)
                 self.load(p, help)
@@ -518,6 +515,10 @@ class Opts:
         exec cmd in globs, locs
         try:
             execfile(defconfig, globs, locs)
+        except SyntaxError,e:
+                raise SyntaxError, \
+                "Errors were found at line %d while processing %s:\n\t%s"\
+                %(e.lineno,defconfig,e.text)
         except:
             if not help: raise
         if help:

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 10 lines · Glauber de Oliveira Costa

I lost some time today using xm create, while invoking 'xm create cfg', because I accidentally had a file called 'cfg' in my current working directory. As the error dumping refers only to 'cfg', it revealed itself somehow tricky to figure out.

I'm attaching a patch that informs the complete path of the file being processing, besides giving a more complete error message that would give more valuable input to help finding any issues.

Already applied.

K.