Skip to contentSkip to conversation

Add git-count-packs, like git-count-objects.

PATCH In review Shawn Pearce 4 participants 6 messages Aug 11, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add git-count-packs, like git-count-objects.

Now that we are starting to save packs rather than unpacking into loose objects its nice to have a way to list the number of current packs and their total size. This can help the user in deciding when its time to run git repack -a -d.

In the future when we actually start to support historical packs vs. active packs we probably should be reporting by default on the number of active packs and ignoring the historical packs.

---
 .gitignore                        |    1 +
 Documentation/git-count-packs.txt |   29 +++++++++++++++++++++++++++++
 Makefile                          |    1 +
 builtin-count-packs.c             |   29 +++++++++++++++++++++++++++++
 builtin.h                         |    1 +
 git.c                             |    1 +
 6 files changed, 62 insertions(+), 0 deletions(-)
.gitignore +1 -0
index b670877..31be347 100644
@@ -23,6 +23,7 @@ git-commit
 git-commit-tree
 git-convert-objects
 git-count-objects
+git-count-packs
 git-cvsexportcommit
 git-cvsimport
 git-cvsserver
Documentation/git-count-packs.txt new file +29 -0
new file mode 100644
index 0000000..1420241
@@ -0,0 +1,29 @@
+git-count-packs(1)
+====================
+
+NAME
+----
+git-count-packs - Reports on packs
+
+SYNOPSIS
+--------
+'git-count-packs'
+
+DESCRIPTION
+-----------
+This counts the number of pack files and disk space consumed by
+them, to help you decide when it is a good time to repack.
+
+
+Author
+------
+Written by Shawn O. Pearce <[email protected]>
+
+Documentation
+--------------
+Documentation by Shawn O. Pearce.
+
+GIT
+---
+Part of the gitlink:git[7] suite
+
Makefile +1 -0
index 2d62efb..b7fd558 100644
@@ -275,6 +275,7 @@ BUILTIN_OBJS = \
 	builtin-check-ref-format.o \
 	builtin-commit-tree.o \
 	builtin-count-objects.o \
+	builtin-count-packs.o \
 	builtin-diff.o \
 	builtin-diff-files.o \
 	builtin-diff-index.o \
builtin-count-packs.c new file +29 -0
new file mode 100644
index 0000000..f5a5940
@@ -0,0 +1,29 @@
+/*
+ * Builtin "git count-packs".
+ *
+ * Copyright (c) 2006 Shawn Pearce
+ */
+
+#include "cache.h"
+#include "builtin.h"
+
+static const char count_packs_usage[] = "git-count-packs";
+
+int cmd_count_packs(int ac, const char **av, const char *prefix)
+{
+	struct packed_git *p;
+	unsigned long packs = 0, pack_size = 0;
+
+	if (!ac)
+		usage(count_packs_usage);
+
+	prepare_packed_git();
+	for (p = packed_git; p; p = p->next) {
+		if (!p->pack_local)
+			continue;
+		packs++;
+		pack_size += p->pack_size / (1024 * 1024);
+	}
+	printf("%lu packs, %lu megabytes\n", packs, pack_size);
+	return 0;
+}
builtin.h +1 -0
index 708a2f2..410577e 100644
@@ -22,6 +22,7 @@ extern int cmd_checkout_index(int argc,
 extern int cmd_check_ref_format(int argc, const char **argv, const char *prefix);
 extern int cmd_commit_tree(int argc, const char **argv, const char *prefix);
 extern int cmd_count_objects(int argc, const char **argv, const char *prefix);
+extern int cmd_count_packs(int argc, const char **argv, const char *prefix);
 extern int cmd_diff_files(int argc, const char **argv, const char *prefix);
 extern int cmd_diff_index(int argc, const char **argv, const char *prefix);
 extern int cmd_diff(int argc, const char **argv, const char *prefix);
git.c +1 -0
index 6475847..9ad0f01 100644
@@ -227,6 +227,7 @@ static void handle_internal_command(int
 		{ "check-ref-format", cmd_check_ref_format },
 		{ "commit-tree", cmd_commit_tree, RUN_SETUP },
 		{ "count-objects", cmd_count_objects, RUN_SETUP },
+		{ "count-packs", cmd_count_packs, RUN_SETUP },
 		{ "diff", cmd_diff, RUN_SETUP | USE_PAGER },
 		{ "diff-files", cmd_diff_files, RUN_SETUP },
 		{ "diff-index", cmd_diff_index, RUN_SETUP },
Signature · 1 line
1.4.3.3.g7d63
#3 lore raw
In reply to Shawn Pearce
Quoted 8 lines · Shawn Pearce
Quoted 7 lines · Junio C Hamano
Quoted 4 lines · Shawn Pearce

Now that we are starting to save packs rather than unpacking into loose objects its nice to have a way to list the number of current packs and their total size. This can help the user in deciding when its time to run git repack -a -d.

Quoted 8 lines
Quoted 1 line

Why not just do "ls -lh $GIT_OBJECT_DIR/pack/pack-*.pack"???

Because whatever we decide to use to make a pack 'active' may not be that simple.

Whatever. It was clearly a very tiny patch put together quickly before dinner tonight, perhaps not worth including at this point. Lets see what comes out of the other pack oriented discussion first.

Perhaps to nod add yet another command to already large set, rename git-count-objects to git-count end enhance it to count both loose objects and packs (or not, and use git-count-objects name).

BTW what does "garbage:" in git-count-objects -v mean? And in what units git-count-objects -v returns "size:" (git-count-objects says "kilobytes", why git-count-objects -v doesn't do the same)?

Signature · 3 lines
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
#1 lore raw
In reply to Shawn Pearce
Quoted 4 lines · Shawn Pearce

Now that we are starting to save packs rather than unpacking into loose objects its nice to have a way to list the number of current packs and their total size. This can help the user in deciding when its time to run git repack -a -d.

Why not just do "ls -lh $GIT_OBJECT_DIR/pack/pack-*.pack"???

#5 lore raw
In reply to Nguyen Thai Ngoc Duy
Quoted 7 lines · Nguyen Thai Ngoc Duy
Quoted 3 lines · Jakub Narebski

Perhaps to not to add yet another command to already large set, rename git-count-objects to git-count, and enhance it to count both loose objects and packs (or not, and use git-count-objects as command name).

Oh if so, I'd suggest git-stats over git-count :-)

Or even git-db-stats (as companion to git-db-init).

Signature · 3 lines
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
#2 lore raw
In reply to Junio C Hamano
Quoted 8 lines · Junio C Hamano
Quoted 4 lines · Shawn Pearce

Now that we are starting to save packs rather than unpacking into loose objects its nice to have a way to list the number of current packs and their total size. This can help the user in deciding when its time to run git repack -a -d.

Why not just do "ls -lh $GIT_OBJECT_DIR/pack/pack-*.pack"???

Because whatever we decide to use to make a pack 'active' may not be that simple.

Whatever. It was clearly a very tiny patch put together quickly before dinner tonight, perhaps not worth including at this point. Lets see what comes out of the other pack oriented discussion first.

#4 lore raw
In reply to Jakub Narebski
Quoted 3 lines · Jakub Narebski

Perhaps to nod add yet another command to already large set, rename git-count-objects to git-count end enhance it to count both loose objects and packs (or not, and use git-count-objects name).

Oh if so, I'd suggest git-stats over git-count :-)