taskstats: cleanup do_exit() path
PATCH 1/2 taskstats: cleanup do_exit() path
do_exit:
taskstats_exit_alloc() ... taskstats_exit_send() taskstats_exit_free()
I think this is not good, let it be a single function exported to the core kernel, taskstats_exit(), which does alloc + send + free itself.
Signed-off-by Oleg Nesterov <[email protected]>
include/linux/taskstats_kern.h | 17 ++--------------- kernel/exit.c | 8 ++------ kernel/taskstats.c | 41 +++++++++++++++-------------------------- 3 files changed, 19 insertions(+), 47 deletions(-)
include/linux/taskstats_kern.h renamed from include/linux/taskstats_kern.h~3_exit +2 -15
@@ -15,12 +15,6 @@extern kmem_cache_t *taskstats_cache;extern struct mutex taskstats_exit_mutex; -static inline void taskstats_exit_free (struct taskstats *tidstats) -{ -if (tidstats) -kmem_cache_free (taskstats_cache, tidstats); -} -static inline void taskstats_tgid_init (struct signal_struct *sig) { sig->stats =NULL ;
@@ -54,17 +48,10 @@ static inline void taskstats_tgid_free(s kmem_cache_free(taskstats_cache, sig->stats); } -extern void taskstats_exit_alloc (struct taskstats **,unsigned int *); -extern void taskstats_exit_send (struct task_struct *,struct taskstats *,int ,unsigned int ); +extern void taskstats_exit (struct task_struct *,int group_dead);extern void taskstats_init_early (void );#else -static inline void taskstats_exit_alloc (struct taskstats **ptidstats,unsigned int *mycpu) -{} -static inline void taskstats_exit_free (struct taskstats *ptidstats) -{} -static inline void taskstats_exit_send (struct task_struct *tsk, -struct taskstats *tidstats, -int group_dead,unsigned int cpu) +static inline void taskstats_exit (struct task_struct *tsk,int group_dead) {}static inline void taskstats_tgid_init (struct signal_struct *sig) {}
kernel/exit.c renamed from kernel/exit.c~3_exit +2 -6
@@ -850,9 +850,7 @@ static void exit_notify(struct task_stru fastcall NORET_TYPE void do_exit(long code) {struct task_struct *tsk = current; -struct taskstats *tidstats;int group_dead; -unsigned int mycpu;profile_task_exit (tsk);
@@ -890,8 +888,6 @@ fastcall NORET_TYPE void do_exit(long co current->comm, current->pid, preempt_count()); -taskstats_exit_alloc (&tidstats, &mycpu); -acct_update_integrals (tsk);if (tsk->mm) {update_hiwater_rss (tsk->mm);
@@ -911,8 +907,8 @@ fastcall NORET_TYPE void do_exit(long co#endif if (unlikely (tsk->audit_context))audit_free (tsk); -taskstats_exit_send (tsk, tidstats, group_dead, mycpu); -taskstats_exit_free (tidstats); + +taskstats_exit (tsk, group_dead);exit_mm (tsk);
kernel/taskstats.c renamed from kernel/taskstats.c~3_exit +15 -26
87 lines not on this page · raw message