Skip to contentSkip to conversation

PROBLEM: can't mkdir() in 2.6.19-rc3

PATCH In review Ingo Saitz 3 participants 8 messages Nov 1, 2006 – Nov 9, 2006

Subsystems (2)
lore
Share & tools
lore

Ingo Saitz

author
#0 lore raw

[1.] One line summary of the problem:

Can't call mkdir() on 2.6.19-r3 nfsd

[2.] Full description of the problem/report:

When I call "mkdir foo" on an nfs mounted volume, the strace of mkdir shows

mkdir("foo", 0777) = -1 EPERM (Operation not permitted)

and the command fails. But if I do a "ls -ld foo" afterwards, the directory got created:

    drwxr-xr-x 2 ingo ingo 4096 2006-11-01 02:54 foo

The server is running 2.6.19-rc3, the client 2.6.18. The version of the nfs-kernel-server ist 1.0.10. This did work with 2.6.18 as nfs server.

[3.] Keywords (i.e., modules, networking, kernel):

nfsd, mkdir, EPERM, 2.6.19-rc3

[4.] Kernel version (from /proc/version):

Linux version 2.6.19-rc3-pinguin20061024.1 (ingo@pinguin) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #1 SMP Tue Oct 24 16:47:01 CEST 2006

[5.] Output of Oops.. message (if applicable) with symbolic information
resolved (see Documentation/oops-tracing.txt)

n/a, strace see above.

[6.] A small shell script or example program which triggers the
problem (if possible)

mkdir foo

[7.] Environment

[7.1.] Software (add the output of the ver_linux script here)

The nfs server is Debian testing, nfs-kernel-server version 1.0.10-2.

$ scripts/ver_linux
If some fields are empty or look unusual you may have an old version.
Compare to the current minimal requirements in Documentation/Changes.

Linux pinguin 2.6.19-rc3-pinguin20061024.1 #1 SMP Tue Oct 24 16:47:01 CEST 2006 x86_64 GNU/Linux

Gnu C                  4.1.2
Gnu make               3.81
binutils               2.17
util-linux             2.12r
mount                  2.12r
module-init-tools      3.2.2
e2fsprogs              1.39
Linux C Library        2.3.6
Dynamic linker (ldd)   2.3.6
Procps                 3.2.7
Net-tools              1.60
Console-tools          0.2.3
Sh-utils               5.97
udev                   100
Modules Loaded         nfs tun crc32 nfsd exportfs lockd sunrpc lp thermal fan button processor ac battery dm_snapshot dm_mirror dm_mod 8250_pnp snd_hda_intel snd_hda_codec snd_pcm_oss snd_mixer_oss sg snd_pcm i2c_i801 snd_timer iTCO_wdt 8250 serial_core i2c_core sr_mod intel_agp parport_pc parport e1000 cdrom floppy evdev snd soundcore snd_page_alloc psmouse rtc pcspkr unix

[7.2.] Processor information (from /proc/cpuinfo):

processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 15
model name : Intel(R) Core(TM)2 CPU 6300 @ 1.86GHz
stepping : 6
cpu MHz : 1862.002
cache size : 2048 KB
physical id : 0
siblings : 2
core id : 0
cpu cores : 2
fpu : yes
fpu_exception : yes
cpuid level : 10
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm syscall nx lm constant_tsc pni monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr lahf_lm
bogomips : 3726.93
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management:

processor : 1
vendor_id : GenuineIntel
cpu family : 6
model : 15
model name : Intel(R) Core(TM)2 CPU 6300 @ 1.86GHz
stepping : 6
cpu MHz : 1862.002
cache size : 2048 KB
physical id : 0
siblings : 2
core id : 1
cpu cores : 2
fpu : yes
fpu_exception : yes
cpuid level : 10
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm syscall nx lm constant_tsc pni monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr lahf_lm
bogomips : 3724.18
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management:

[7.3.] Module information (from /proc/modules):
[7.4.] Loaded driver and hardware information (/proc/ioports, /proc/iomem) [7.5.] PCI information ('lspci -vvv' as root)
[7.6.] SCSI information (from /proc/scsi/scsi)

Please tell me if you think any of these are relevant.

[7.7.] Other information that might be relevant to the problem
(please look in /proc and include all information that you think to be relevant):

The kernel is compiled for the x86_64 arch, the userspace and the nfs kernel server code is still compiled for i386. The exported filesystems are all ext3.

$ grep 'NFS\|RPC\|LOCKD' /boot/config-`uname -r`
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_NFS_FS=m
CONFIG_NFS_V3=y
# CONFIG_NFS_V3_ACL is not set
CONFIG_NFS_V4=y
# CONFIG_NFS_DIRECTIO is not set
CONFIG_NFSD=m
CONFIG_NFSD_V3=y
# CONFIG_NFSD_V3_ACL is not set
CONFIG_NFSD_V4=y
CONFIG_NFSD_TCP=y
CONFIG_LOCKD=m
CONFIG_LOCKD_V4=y
CONFIG_NFS_COMMON=y
CONFIG_SUNRPC=m
CONFIG_SUNRPC_GSS=m
CONFIG_RPCSEC_GSS_KRB5=m
CONFIG_RPCSEC_GSS_SPKM3=m
CONFIG_RXRPC=m

[X.] Other notes, patches, fixes, workarounds:

Signature · 2 lines
Man hat schon Igel nach Westen kotzen sehen!
(alte indianische Weisheit)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

author
#1 lore raw

Re: PROBLEM: can't mkdir() in 2.6.19-rc3 / 2.6.19-rc5

Quoted 3 lines · Ingo Saitz

[1.] One line summary of the problem:

Can't call mkdir() on 2.6.19-r3 nfsd

This is still present in 2.6.19-rc5 (-rc4 was completely broken, see <[email protected]>), same host.

Ingo

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#2 lore raw
In reply to Ingo Saitz
Quoted 6 lines · Ingo Saitz

[2.] Full description of the problem/report:

When I call "mkdir foo" on an nfs mounted volume, the strace of mkdir shows

mkdir("foo", 0777) = -1 EPERM (Operation not permitted)

Quoted 7 lines

and the command fails. But if I do a "ls -ld foo" afterwards, the directory got created:

    drwxr-xr-x 2 ingo ingo 4096 2006-11-01 02:54 foo

The server is running 2.6.19-rc3, the client 2.6.18. The version of the nfs-kernel-server ist 1.0.10. This did work with 2.6.18 as nfs server.

Do you have the "async" option set on this export? (What does

exportfs -v

say?)

--b.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#3 lore raw

PATCH 1/1 nfsd: fix spurious error return from nfsd_create in async case

Commit 6264d69d7df654ca64f625e9409189a0e50734e9 modified the nfsd_create() error handling in such a way that nfsd_create will usually return nfserr_perm even when succesful, if the export has the async export option.

This introduced a regression that could cause mkdir() to always return a permissions error, even though the directory in question was actually succesfully created.

fs/nfsd/vfs.c +1 -1
index 1a7ad8c..bb4d926 100644
@@ -1177,7 +1177,7 @@ nfsd_create(struct svc_rqst *rqstp, stru
 	/*
 	 * Get the dir op function pointer.
 	 */
-	err = nfserr_perm;
+	err = 0;
 	switch (type) {
 	case S_IFREG:
 		host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Acked-by on v1 1/1
#4 lore raw

Re: [PATCH] nfsd: fix spurious error return from nfsd_create in async case

Quoted 10 lines · On Wednesday November 8, [email protected] wrote:

Commit 6264d69d7df654ca64f625e9409189a0e50734e9 modified the nfsd_create() error handling in such a way that nfsd_create will usually return nfserr_perm even when succesful, if the export has the async export option.

This introduced a regression that could cause mkdir() to always return a permissions error, even though the directory in question was actually succesfully created.

Thanks Bruce. I checked the rest of that commit and I don't think the same problem occurs anywhere else.

There is an 'err = nfserr_acces' in nfsd_lookup which is now dead code... but I guess it already was before the patch.

That "err = " that you fixed was dead code before the patch, but became a live problem.....

Thanks.
NeilBrown

Quoted 6 lines
fs/nfsd/vfs.c +0 -0
index 1a7ad8c..bb4d926 100644

fs/nfsd/vfs.c nfsd_create(struct svc_rqst *rqstp, stru · line 1183

Quoted 8 lines
fs/nfsd/vfs.c +1 -1
@@ -1177,7 +1177,7 @@ nfsd_create(struct svc_rqst *rqstp, stru
 	/*
 	 * Get the dir op function pointer.
 	 */
-	err = nfserr_perm;
+	err = 0;
 	switch (type) {
 	case S_IFREG:
 		host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#5 lore raw

Re: [PATCH] nfsd: fix spurious error return from nfsd_create in async case

Quoted 2 lines · Neil Brown

Thanks Bruce. I checked the rest of that commit and I don't think the same problem occurs anywhere else.

Good, thanks, I didn't think to do that.

Quoted 5 lines

There is an 'err = nfserr_acces' in nfsd_lookup which is now dead code... but I guess it already was before the patch.

That "err = " that you fixed was dead code before the patch, but became a live problem.....

Yeah, that probably contributed to the confusion.

--b.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

author
#6 lore raw
In reply to J. Bruce Fields
Quoted 5 lines · J. Bruce Fields

Do you have the "async" option set on this export? (What does

exportfs -v

say?)

Yes, i do use async as optin. exportfs -v says:

/DATA/media 10.4.0.225(rw,async,wdelay,root_squash,anonuid=65534,anongid=65534)

Also, your patch in <[email protected]> fixes this problem. Thanks.

Ingo

Signature · 2 lines
Man hat schon Igel nach Westen kotzen sehen!
(alte indianische Weisheit)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#7 lore raw
Quoted 5 lines · Ingo Saitz
Quoted 4 lines · J. Bruce Fields

Do you have the "async" option set on this export? (What does

exportfs -v

Quoted 8 lines
Quoted 1 line

say?)

Yes, i do use async as optin. exportfs -v says:

/DATA/media 10.4.0.225(rw,async,wdelay,root_squash,anonuid=65534,anongid=65534)

Also, your patch in <[email protected]> fixes this problem. Thanks.

Thanks for the confirmation.--b.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs