Skip to contentSkip to conversation

More list debugging context.

PATCH Dave Jones 1 participant 1 message Nov 1, 2006 Library code

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Print the other (hopefully) known good pointer when list_head debugging too, which may yield additional clues.

Also fix for 80-columns to win akpm brownie points.

lib/list_debug.c +6 -4
index 7ba9d82..4350ba9 100644
@@ -21,13 +21,15 @@ void __list_add(struct list_head *new,
 			      struct list_head *next)
 {
 	if (unlikely(next->prev != prev)) {
-		printk(KERN_ERR "list_add corruption. next->prev should be %p, but was %p\n",
-			prev, next->prev);
+		printk(KERN_ERR "list_add corruption. next->prev should be "
+			"prev (%p), but was %p. (next=%p).\n",
+			prev, next->prev, next);
 		BUG();
 	}
 	if (unlikely(prev->next != next)) {
-		printk(KERN_ERR "list_add corruption. prev->next should be %p, but was %p\n",
-			next, prev->next);
+		printk(KERN_ERR "list_add corruption. prev->next should be "
+			"next (%p), but was %p. (prev=%p).\n",
+			next, prev->next, prev);
 		BUG();
 	}
 	next->prev = new;
Signature · 1 line
http://www.codemonkey.org.uk