Skip to contentSkip to conversation

+ revert-iscsi-build-failure-use-depends-instead-of.patch added to -mm tree

DISCUSSION Stefan Richter 1 participant 1 message Nov 2, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 16 lines

From: Randy Dunlap <[email protected]>

Remove all (2) "select NET" instances from all kernel Kconfig files. Use "depends on" for them instead. As Roman Zippel commented, "please don't select NET, it's way too broad."

This affects all IEEE1394 drivers and some SCSI drivers. Networking (NET) will have to be enabled before any IEEE1394 or a few SCSI drivers can be enabled. In particular for SCSI, the QLogic ISP4xxx driver (SCSI_QLA_ISCSI) and any FiberChannel drivers are affected.

Cc James Bottomley <[email protected]>
Cc Stefan Richter <[email protected]>
Cc Roman Zippel <[email protected]>
Quoted 6 lines

---

 drivers/ieee1394/Kconfig     |    5 ++++-
 drivers/scsi/Kconfig         |   13 +++++++++----
 drivers/scsi/qla4xxx/Kconfig |    8 ++++----
 3 files changed, 17 insertions(+), 9 deletions(-)

[...]

I'm OK with that change. You could have submitted the IEEE 1394 part separately though.

A comment on the patch description: Only the eth1394 driver and the ieee1394 core driver depend directly on NET. (All other FireWire drivers depend on ieee1394 of course.) ieee1394's dependency on NET is planned to be removed by a minor change to its implementation but we don't have a deadline for this, as usual...

Signature · 3 lines
Stefan Richter
-=====-=-==- =-== ---=-
http://arcgraph.de/sr/