Skip to contentSkip to conversation

a minor fix for set_mb() in Documentation/memory-barriers.txt

PATCH In review Oleg Nesterov 2 participants 2 messages Nov 6, 2006 – Nov 8, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 a minor fix for set_mb() in Documentation/memory-barriers.txt

set_mb() is used by set_current_state() which needs mb(), not wmb(). I think it would be right to assume that set_mb() implies mb(), all arches seem to do just this.

Documentation/memory-barriers.txt renamed from Documentation/memory-barriers.txt~ +1 -1
@@ -1016,7 +1016,7 @@ There are some more advanced barrier fun
 
  (*) set_mb(var, value)
 
-     This assigns the value to the variable and then inserts at least a write
+     This assigns the value to the variable and then inserts a full memory
      barrier after it, depending on the function.  It isn't guaranteed to
      insert anything more than a compiler barrier in a UP compilation.
 
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Oleg Nesterov

set_mb() is used by set_current_state() which needs mb(), not wmb(). I think it would be right to assume that set_mb() implies mb(), all arches seem to do just this.

Yes, you're right. Copy'n'paste error from the text about set_wmb() I think.