Skip to contentSkip to conversation

include/linux/nfsd/nfsfh.h: NULL dereference

DISCUSSION Adrian Bunk 1 participant 1 message Nov 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following:

<-- snip -->

...
static __inline__ struct svc_fh *
fh_copy(struct svc_fh *dst, struct svc_fh *src)

{
        if (src->fh_dentry || src->fh_locked) {
                struct dentry *dentry = src->fh_dentry;
                printk(KERN_ERR "fh_copy: copying %s/%s, already verified!\n",
                        dentry->d_parent->d_name.name, dentry->d_name.name);
        }
                        
        *dst = *src;
        return dst;
}

...

<-- snip -->

src->fh_dentry is being dereferenced when we discover it's NULL...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed