ARM: OMAP: OMAP310 i2c fix
Subsystems (2)
PATCH 1/1 ARM: OMAP: OMAP310 i2c fix
Hi,
when I turned on i2c on my omap310 based palmz71 and booted the kernel, it hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small patch.
arch/arm/plat-omap/dsp/dsp_common.c +1 -1
@@ -273,7 +273,7 @@ dspmem_size =0 ;#ifdef CONFIG_ARCH_OMAP15XX -if (cpu_is_omap1510 ()) { +if (cpu_is_omap15xx ()) { dspmem_base =OMAP1510_DSP_BASE ; dspmem_size =OMAP1510_DSP_SIZE ; daram_base =OMAP1510_DARAM_BASE ;
Dne neděle 12 listopad 2006 19:30 jste napsal(a):
Quoted 5 lines
Hi,
when I turned on i2c on my omap310 based palmz71 and booted the kernel, it hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small patch.
forgot to add this ;-)
Quoted 9 lines · Marek Vašut
Dne neděle 12 listopad 2006 19:30 jste napsal(a):
Quoted 5 lines
Hi,
when I turned on i2c on my omap310 based palmz71 and booted the kernel, it hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small patch.
forgot to add this ;-)
Signed-off-by Marek Vašut <[email protected]>
Just to confirm your patch comment. Did you enabled OMAP_DSP or I2C? as you had modified dsp_common.c. Going the generic way, dsp_common.c should pick up memory addresses from arch- specific files, but as omap_dsp_init is called in arch_init, I don't know, what would be the cleaner way to do it.
Dne pondělí 13 listopad 2006 10:32 jste napsal(a):
Quoted 10 lines · Marek Vašut
Quoted 9 lines
Dne neděle 12 listopad 2006 19:30 jste napsal(a):
Quoted 5 lines
Hi,
when I turned on i2c on my omap310 based palmz71 and booted the kernel, it hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small patch.
forgot to add this ;-)
Quoted 7 lines
Quoted 1 line
Signed-off-by Marek Vašut <[email protected]>Just to confirm your patch comment. Did you enabled
OMAP_DSPor I2C? as you had modifieddsp_common.c. Going the generic way,dsp_common.cshould pick up memory addresses from arch- specific files, but asomap_dsp_initis called inarch_init, I don't know, what would be the cleaner way to do it.
yes, I enabled i2c.
Quoted 13 lines · Marek Vašut
Dne pondělí 13 listopad 2006 10:32 jste napsal(a):
Quoted 12 lines · Marek Vašut
Quoted 10 lines
Dne neděle 12 listopad 2006 19:30 jste napsal(a):
Quoted 5 lines
Hi,
when I turned on i2c on my omap310 based palmz71 and booted the kernel, it hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small patch.
forgot to add this ;-)
Signed-off-by Marek Vašut <[email protected]>
Quoted 7 lines
Quoted 5 lines
Just to confirm your patch comment. Did you enabled
OMAP_DSPor I2C? as you had modifieddsp_common.c. Going the generic way,dsp_common.cshould pick up memory addresses from arch- specific files, but asomap_dsp_initis called inarch_init, I don't know, what would be the cleaner way to do it.yes, I enabled i2c.
Pushing this today.
Tony