Skip to contentSkip to conversation

aoe: Add forgotten NULL at end of attribute list in aoeblk.c

PATCH In review Dennis Stosberg 2 participants 2 messages Nov 13, 2006 – Nov 16, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aoe: Add forgotten NULL at end of attribute list in aoeblk.c

This caused the system to stall when the aoe module was loaded. The error was introduced in commit 4ca5224f3ea4779054d96e885ca9b3980801ce13

---

The log of the caused error can be found at
http://stosberg.net/tmp/aoe_trace.txt

 drivers/block/aoe/aoeblk.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/block/aoe/aoeblk.c +1 -0
index d433f27..aa25f8b 100644
@@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = {
 	&disk_attr_mac.attr,
 	&disk_attr_netif.attr,
 	&disk_attr_fwver.attr,
+	NULL
 };
 
 static const struct attribute_group attr_group = {
Signature · 1 line
1.4.3.3
#1 lore raw
Quoted 2 lines · Dennis Stosberg

This caused the system to stall when the aoe module was loaded. The error was introduced in commit 4ca5224f3ea4779054d96e885ca9b3980801ce13

Boy, I've been totally spoiled by the gitweb at kernel.org. It's been unavailable lately.

Anyway, thanks for the fix. It looks good to me if it looks good to Greg---after a google search it appears that your patch is a followup to his consolidation of the attributes.

Quoted 23 lines

---

The log of the caused error can be found at
http://stosberg.net/tmp/aoe_trace.txt

 drivers/block/aoe/aoeblk.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/block/aoe/aoeblk.c +1 -0
index d433f27..aa25f8b 100644
@@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = {
 	&disk_attr_mac.attr,
 	&disk_attr_netif.attr,
 	&disk_attr_fwver.attr,
+	NULL
 };
 
 static const struct attribute_group attr_group = {
Signature · 1 line
1.4.3.3
Signature · 1 line
  Ed L Cashin <[email protected]>