ACKVEC: Optimization - Do not traverse records if none will be found
PATCH 5/5 ACKVEC: Optimization - Do not traverse records if none will be found
Do not traverse the list of ack vector records [proportional to window size] when we know we will not find what we are looking for. This is especially useful because ack vectors are checked twice:
1) Upon parsing of options.
2) Upon notification of a new ack.
All of the work will occur during check #1. Therefore, when check #2 is performed, no new work will be done. This is now "detected" and there is no performance hit when doing #2.
Signed-off-by Andrea Bittau <[email protected]>
Signed-off-by Gerrit Renker <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
------------------------------------------------------------------------------
ackvec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
------------------------------------------------------------------------------
net/dccp/ackvec.c +2 -1
@@ -383,7 +383,8 @@ void dccp_ackvec_check_rcv_ackno(struct (unsigned long long)avr->dccpavr_ack_ackno);dccp_ackvec_throw_record (av, avr);break ; - } + }else if (avr->dccpavr_ack_seqno > ackno) +break ;/* old news */ } }