Skip to contentSkip to conversation

dell_rbu: fix error check

PATCH New Akinobu Mita 1 participant 1 message Nov 14, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dell_rbu: fix error check

platform_device_register_simple() returns error code as pointer when it fails. The return value should be checked by IS_ERR().

 drivers/firmware/dell_rbu.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/firmware/dell_rbu.c +4 -5
Index: work-fault-inject/drivers/firmware/dell_rbu.c
===================================================================
@@ -705,17 +705,16 @@ static struct bin_attribute rbu_packet_s
 
 static int __init dcdrbu_init(void)
 {
-	int rc = 0;
+	int rc;
 	spin_lock_init(&rbu_data.lock);
 
 	init_packet_head();
-	rbu_device =
-		platform_device_register_simple("dell_rbu", -1, NULL, 0);
-	if (!rbu_device) {
+	rbu_device = platform_device_register_simple("dell_rbu", -1, NULL, 0);
+	if (IS_ERR(rbu_device)) {
 		printk(KERN_ERR
 			"dell_rbu:%s:platform_device_register_simple "
 			"failed\n", __FUNCTION__);
-		return -EIO;
+		return PTR_ERR(rbu_device);
 	}
 
 	rc = sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);