Skip to contentSkip to conversation

Don't give bad kprobes example aka ") < 0))" typo

PATCH In review Alexey Dobriyan 2 participants 2 messages Nov 15, 2006 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't give bad kprobes example aka ") < 0))" typo

---

 Documentation/kprobes.txt |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/kprobes.txt +3 -2
@@ -442,9 +442,10 @@ static int __init kprobe_init(void)
 	kp.fault_handler = handler_fault;
 	kp.symbol_name = "do_fork";
 
-	if ((ret = register_kprobe(&kp) < 0)) {
+	ret = register_kprobe(&kp);
+	if (ret < 0) {
 		printk("register_kprobe failed, returned %d\n", ret);
-		return -1;
+		return ret;
 	}
 	printk("kprobe registered\n");
 	return 0;
#1 lore raw
Quoted 9 lines · Alexey Dobriyan

---

 Documentation/kprobes.txt |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Documentation/kprobes.txt static int __init kprobe_init(void) · line 448

Quoted 9 lines
Documentation/kprobes.txt +3 -2
@@ -442,9 +442,10 @@ static int __init kprobe_init(void)
 	kp.fault_handler = handler_fault;
 	kp.symbol_name = "do_fork";
 
-	if ((ret = register_kprobe(&kp) < 0)) {
+	ret = register_kprobe(&kp);
+	if (ret < 0) {
 		printk("register_kprobe failed, returned %d\n", ret);
-		return -1;
+		return ret;

This looks good, thanks.