Skip to contentSkip to conversation

security/seclvl.c: fix time wrap (CVE-2005-4352)

PATCH New Adrian Bunk 1 participant 1 message Nov 15, 2006 Security (LSM)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 security/seclvl.c: fix time wrap (CVE-2005-4352)

initlvl=2 in seclvl gives the guarantee
"Cannot decrement the system time".

But it was possible to set the time to the maximum unixtime value (19 Jan 2038) resulting in a wrap to the minimum value.

This patch fixes this by disallowing setting the time to any date after 2031 with initlvl=2.

This patch does not apply to kernel 2.6.19 since the seclvl module was already removed in this kernel.

security/seclvl.c renamed from security/seclvl.c.old +2 -0
@@ -381,6 +381,8 @@ static int seclvl_settime(struct timespe
 				      current->group_leader->pid);
 			return -EPERM;
 		}		/* if attempt to decrement time */
+		if (tv->tv_sec > 1924988400)	/* disallow dates after 2030) */
+			return -EPERM;		/* CVE-2005-4352 */
 	}			/* if seclvl > 1 */
 	return 0;
 }